buildroot/support/scripts, branch 2018.02.1

support/check-uniq-files: support weird locales and filenames

2018-04-06T18:09:19+00:00

Currently, when a filename contains characters not representable in the user's locale, we fail hard, especially when the host python is python3. This is because python2 and python3 handle encoding/decoding strings differently, with python3 presumable doing the right thing, but it breaks on some systems, while python2 presumable does the wrong thing, but it works everywhere. (Just joking, obviously...) Part of the issue being that the csv reader in python2 is broken with UTF8. We fix the issue by ditching the csv reader, and simply read the file in binary mode, manually partitioning the lines on the first comma. Then, we use the binary-encoded (really, un-encoded) package names and filenames as values and keys, respectively. Finally, for each filename or package we need to print, we try to decode them with the defaults for the user settings, but catch any decoding exception and fall back to dumping the raw, binary values. Which codec is used by default differs between Python version, but in all cases something sane is printed at least. Thanks a lot to Arnout for the live help doing this patch. :-) Reported-by: Jaap Crezee Signed-off-by: "Yann E. MORIN" Cc: Arnout Vandecappelle Cc: Jaap Crezee [Arnout: commit log improvement] Signed-off-by: Arnout Vandecappelle (Essensium/Mind) (cherry picked from commit 5563a1c6a48716debe2983869ddb757318094dce) Signed-off-by: Peter Korsgaard

support/check-bin-arch: exclude kernel modules for merged /usr

2018-03-30T20:11:20+00:00

When using a merged /usr, the kernel module path is really /usr/lib/modules, as /lib is a symlink to usr/lib . Signed-off-by: "Yann E. MORIN" Cc: Thomas Petazzoni Cc: Peter Korsgaard Reviewed-by: Peter Korsgaard Signed-off-by: Peter Korsgaard (cherry picked from commit 1b9a57442d0a234b03585235f516d755372f29b3) Signed-off-by: Peter Korsgaard

spport/check-bin-arch: accept arbitrary per-package ignore paths

2018-03-30T20:11:10+00:00

Some packages (mostly, out-of-tree) may want to install binary blobs for another architecture, outside the locations we currently exclude, like in /opt or whatever... Add support in check-bin-arch to accept any arbitrary location, that individual package can each request to excude from the check, when they are installed. Signed-off-by: "Yann E. MORIN" Cc: Peter Korsgaard Cc: Thomas Petazzoni Signed-off-by: Peter Korsgaard (cherry picked from commit 01d90f0d093ff16ab3c1a9466430cee6fb7842d8) Signed-off-by: Peter Korsgaard

support/scripts/check-uniq-files: add indices in format string

2018-03-03T16:17:41+00:00

Using {} in format strings is only supported in sufficiently recent Python versions. Python 2.6 doesn't support this, and only format strings with numbered arguments: {0}, {1}, etc. Python 2.7: $ python -c 'print("foo {}".format(12))' foo 12 $ python -c 'print("foo {0}".format(12))' foo 12 Python 2.6: $ python -c 'print("foo {}".format(12))' Traceback (most recent call last): File "", line 1, in ValueError: zero length field name in format $ python -c 'print("foo {0}".format(12))' foo 12 Signed-off-by: Thomas Petazzoni Acked-by: "Yann E. MORIN" Signed-off-by: Peter Korsgaard

check-bin-arch: skip /lib/modules to allow 32-bit userland on 64-bit arch

2018-02-25T22:16:05+00:00

The script check-bin-arch fails as follows on a config for PowerPC e6500 (64-bit CPU) with BR2_ARCH="powerpc" (32-bit userland desired): ERROR: architecture for "/lib/modules/..../lib/libcrc32c.ko" is "PowerPC64", should be "PowerPC" This situation is perfectly acceptable: the kernel is 64-bit and so are its modules, even though userland is 32-bit. To keep check-bin-arch and its caller simple, just skip /lib/modules/ entirely, like is done for /lib/firmware and some others. Signed-off-by: Thomas De Schampheleire Reviewed-by: "Yann E. MORIN" Signed-off-by: Thomas Petazzoni

size-stats: fix code style

2018-01-29T22:14:24+00:00

Fix these warnings: E302 expected 2 blank lines, found 1 E305 expected 2 blank lines after class or function definition, found 1 E713 test for membership should be 'not in' Signed-off-by: Ricardo Martincoski Cc: Thomas De Schampheleire Cc: Thomas Petazzoni Signed-off-by: Thomas Petazzoni

pycompile: fix code style

2018-01-29T22:14:24+00:00

Fix these warnings: E302 expected 2 blank lines, found 1 E305 expected 2 blank lines after class or function definition, found 1 Signed-off-by: Ricardo Martincoski Cc: Thomas Petazzoni Cc: Yegor Yefremov Reviewed-by: Yegor Yefremov Signed-off-by: Thomas Petazzoni

graph-build-time: fix code style

2018-01-29T22:14:24+00:00

Fix these warnings: E201 whitespace after '[' E202 whitespace before ']' E302 expected 2 blank lines, found 1 E305 expected 2 blank lines after class or function definition, found 1 Ignore these warnings: E402 module level import not at top of file Signed-off-by: Ricardo Martincoski Cc: Thomas Petazzoni Cc: Yann E. MORIN Signed-off-by: Thomas Petazzoni

check-uniq-files: fix code style

2018-01-29T22:14:24+00:00

Fix these warnings: E128 continuation line under-indented for visual indent E302 expected 2 blank lines, found 1 E305 expected 2 blank lines after class or function definition, found 1 Signed-off-by: Ricardo Martincoski Cc: Yann E. MORIN Signed-off-by: Thomas Petazzoni

graph-depends: fix code style

2018-01-29T22:14:24+00:00

Fix these warnings: E122 continuation line missing indentation or outdented E127 continuation line over-indented for visual indent E128 continuation line under-indented for visual indent E202 whitespace before ']' E221 multiple spaces before operator E225 missing whitespace around operator E231 missing whitespace after ',' E302 expected 2 blank lines, found 1 E305 expected 2 blank lines after class or function definition, found 1 E502 the backslash is redundant between brackets E713 test for membership should be 'not in' Signed-off-by: Ricardo Martincoski Cc: Thomas Petazzoni Signed-off-by: Thomas Petazzoni