buildroot/package/pkgconf, branch 2019.02-op-build

package/pkgconf: fix behavior of pkg-config --version

2019-01-03T20:55:15+00:00

For some odd reason, the new pkg-config 1.5.3 changed the behavior of "pkg-config --version": as soon as another argument than "--version" is passed, the code assumes the user wanted to run "--modversion" instead. Sadly, this breaks badly with our pkg-config wrapper that unconditionally passes --static to pkg-config when BR2_STATIC_LIBS=y. When ffmpeg calls "pkg-config --version" to test if pkg-config is available and functional, it's actually "pkg-config --static --version" that gets executed. pkg-config assumes that the user wanted to use --modversion and bails out with an error. This causes a build failure of ffmpeg in BR2_STATIC_LIBS=y configuration. This misbehavior of pkg-config has been reported upstream at https://git.dereferenced.org/pkgconf/pkgconf/issues/19, but until it gets fixed, we work around the issue by reverting the commit that does the "hey let's assume you're using --modversion if --version is passed with more than one argument". Fixes: http://autobuild.buildroot.net/results/ed82a95e1866ea2caadbb3433b2a255b2cf621d2/ (and plenty of other ffmpeg + BR2_STATIC_LIBS=y build failures) Signed-off-by: Thomas Petazzoni Reviewed-by: "Yann E. MORIN" Signed-off-by: Thomas Petazzoni

package/pkgconf: add patch to restore pre-1.5.3 behavior for sysroot prefixing

2018-12-21T15:34:59+00:00

Prior to the bump to version 1.5.3 in commit 4e423669399ad8389edd81761ea5c9cc26bf312d, we had a patch on pkgconf that ensures only some variables containing paths were prefixed by the sysroot directory when queried through pkg-config. This patch was dropped as part of the 1.5.3 bump, but it turns out we really need something like this, or a significant number of changes need to be done to existing packages. Indeed, pkg-config has no notion of which variable/path gets used at build time vs. which variable/path gets used at runtime. Prefixing with the sysroot the paths used at build time works and is desirable, but prefixing the paths used at runtime doesn't work. This commit should fix a large number of remaining build failures related to pkgconf 1.5.3, and should allow reverting a significant number of workarounds. Signed-off-by: Thomas Petazzoni Acked-by: "Yann E. MORIN" Signed-off-by: Thomas Petazzoni

package/pkgconf: purge trailing '/' from PKGCONF_SITE

2018-12-10T21:00:50+00:00

_SITE cannot have a trailing slash. This was not detected by the check in generic-package because it is a host-only package without Config.in symbol. Signed-off-by: Carlos Santos Signed-off-by: Arnout Vandecappelle (Essensium/Mind)

package/pkgconf: bump to 1.5.3, change upstream

2018-12-09T15:56:49+00:00

The pkgconf project now has a website at pkgconf.org, and hosts its tarballs at https://distfiles.dereferenced.org/pkgconf/, so this commit updates the upstream location, and uses the xz-compressed tarball as well. pkgconf is bumped to 1.5.3. What prompted this update is the fact that GStreamer uses the --define-prefix option when calling pkg-config, and this option didn't exist in pkgconf 0.9.2. The patch 0001-Fix-all-variables-sysroot-prefix-problem.patch is dropped, because pkgconf now behaves properly, by prefixing all paths with the sysroot. This has been verified by testing libdir and includedir in zlib.pc, and adding some dummy pkgdatadir, mapdir and sdkdir variables: $ cat staging/usr/lib/pkgconfig/zlib.pc prefix=/usr exec_prefix=${prefix} libdir=${exec_prefix}/lib sharedlibdir=${libdir} includedir=${prefix}/include pkgdatadir=${prefix}/pouet mapdir=${prefix}/this/is/map/dir sdkdir=${prefix}/this/is/sdk/dir [...] $ ./host/bin/pkg-config --variable=libdir zlib ./host/bin/../arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib $ ./host/bin/pkg-config --variable=includedir zlib ./host/bin/../arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include $ ./host/bin/pkg-config --variable=mapdir zlib ./host/bin/../arm-buildroot-linux-uclibcgnueabi/sysroot/usr/this/is/map/dir $ ./host/bin/pkg-config --variable=sdkdir zlib ./host/bin/../arm-buildroot-linux-uclibcgnueabi/sysroot/usr/this/is/sdk/dir $ ./host/bin/pkg-config --variable=pkgdatadir zlib ./host/bin/../arm-buildroot-linux-uclibcgnueabi/sysroot/usr/pouet So, the 0001-Fix-all-variables-sysroot-prefix-problem patch is no longer necessary. Signed-off-by: Thomas Petazzoni Tested-by: "Yann E. MORIN" Acked-by: "Yann E. MORIN" Signed-off-by: Thomas Petazzoni

Merge branch 'next'

2018-03-05T20:04:14+00:00

Signed-off-by: Peter Korsgaard

pkgconf: pkg-config.in: exec pkgconf

2018-02-25T20:55:28+00:00

Replace the shell script with pkgconf without creating a new process. Signed-off-by: Gaël PORTAY Signed-off-by: Thomas Petazzoni

pkgconf: pkg-config.in: double quote $@

2018-02-25T20:55:25+00:00

The shell expands "$@" as "$1" "$2" "$3"... while it expands $@ as $1 $2 $3. With the second form, we loses spaces in positional parameters. As example, the following call pkg-config --cflags "one two" three is wrapped as pkgconf --cflags one two three while we are expecting pkgconf --cflags "one two" three "$@" is really useful when writing wrappers. It passes the positional arguments *as* they are given. Double quote $@ to prevent from splitting elements. Signed-off-by: Gaël PORTAY Signed-off-by: Thomas Petazzoni

package/*/Config.in.host: fix help text check-package warnings

2018-02-14T20:25:04+00:00

This commit fixes the warnings reported by check-package on the help text of all package Config.in.host files, related to the formatting of the help text: should start with a tab, then 2 spaces, then at most 62 characters. Signed-off-by: Gaël PORTAY Signed-off-by: Thomas Petazzoni

pkgconf: use relative path to STAGING_DIR instead of absolute path

2017-12-31T17:24:11+00:00

The pkg-config wrapper script is currently generated with absolute paths to $(STAGING_DIR). However, this will not work properly with per-package SDK, and each package will be built with a different STAGING_DIR value. In order to fix this, we adjust how the pkg-config wrapper script is generated, so that it uses a relative path to itself: the sysroot (i.e STAGING_DIR) is always located in $(path of pkg-config)/../$(STAGING_SUBDIR). This change is independent from the per-package SDK work, and could be applied independently from it. Signed-off-by: Thomas Petazzoni Reviewed-by: "Yann E. MORIN" Signed-off-by: Thomas Petazzoni

package/*/Config.in: fix help text check-package warnings

2017-12-18T08:22:54+00:00

This commit fixes the warnings reported by check-package on the help text of all package Config.in files, related to the formatting of the help text: should start with a tab, then 2 spaces, then at most 62 characters. The vast majority of warnings fixed were caused by too long lines. A few warnings were related to spaces being used instead of a tab to indent the help text. Signed-off-by: Thomas Petazzoni