buildroot/package/pkg-generic.mk, branch 2017.08

fs: add pre- and post-command hooks

2017-08-02T18:58:27+00:00

In some cases, the directory structure we want in the filesystem is not exactly what we have in target/ For example, when systemd is used on a read-only rootfs, /var must be a tmpfs. However, we may have packages that install stuff in there, and set important rights (via the permission-table). So, at build time, we need /var to be a symlink to the remanent location (/usr/share/factory) while at runtime we need /var to be a directory. One option would have been to have /var as a real directory even during build time, and in a target-finalize hook, move everything out of there and into the "factory" location. However, that's not possible because it's too early: some packages may want to set ownership and/or acces rights on directories or files in /var, and this is only done in the fakeroot script, which is called only later during the assembling of the filesystem images. Also, there would have been no way to undo the tweak (i.e. we need to restore the /var symlink so that subsequent builds continue to work) if it were done as a target-finalize hook. The only solution is to allow packages to register pre- and post-hooks that are called right before and right after the rootfs commands are executed, and inside in the fakeroot script. We can however not re-use the BR2_ROOTFS_POST_FAKEROOT_SCRIPT feature either because it is done before the filesystem command, but there is nothing that is done after. Also, we don't want to add to, and modify a user-supplied variable. So, we introduce two new variables that packages can set to add the commands they need to run to tweak the filesystem right at the last moment. Those hooks are not documented on-purpose; they are probably going to only ever be used by systemd. Signed-off-by: "Yann E. MORIN" Reviewed-by: Romain Naour Signed-off-by: Arnout Vandecappelle (Essensium/Mind) Signed-off-by: Thomas Petazzoni

core/legal-info: properly check hashes of license files for host packages

2017-07-29T20:34:08+00:00

When called for a host package, we currently miss the hash file, because it is named after the target package. Fix that by using the package raw-name. Signed-off-by: "Yann E. MORIN" Cc: Thomas Petazzoni Cc: Luca Ceresoli Signed-off-by: Thomas Petazzoni

pkg-generic: make PKG_DL_DIR equal to DL_DIR

2017-07-22T21:36:47+00:00

This variable is currently not used by anyone. The value is changed to match the path to DL_DIR. The next patch will introduce the use of PKG_DL_DIR for packages that use specific EXTRACT_CMDS. And then we will be able to change the value of PKG_DL_DIR to create a new directory structure in DL_DIR with a subdirectory for each package. Signed-off-by: Maxime Hadjinlian Reviewed-by: Arnout Vandecappelle (Essensium/Mind) Signed-off-by: Thomas Petazzoni

core/pkg-generic: add variable to skip skeleton dependency

2017-07-22T13:34:01+00:00

We currently skip the skeleton dependency by checking if the current package is the skeleton. We are going to introduce more skeleton-related packages, so we need a way to exclude the skeleton dependency for those, or we'd get a circular dependency, for the same reason we need to skip the toolchain dependency. Instead of checking for all the skeleton-providing packages in the core infra, add a new package options so that packages can express they do not need the dependency on the skeleton, like we have an option to avoid the depednency on the toolchain. The only packages that will use that option are probably the skeletons, so we need not document this variable, like we did not document the option to exclude the dependency on the toolchain. Signed-off-by: "Yann E. MORIN" Reviewed-by: Romain Naour Reviewed-by: Arnout Vandecappelle (Essensium/Mind) Signed-off-by: Thomas Petazzoni

core/pkg-util: pass package directory and name when saving license files

2017-07-03T16:03:20+00:00

This will be useful when checking the hashes of the license files. [Peter: use '.' as buildroot directory so /buildroot.hash isn't checked] Signed-off-by: "Yann E. MORIN" Cc: Luca Ceresoli Cc: Peter Korsgaard Cc: Rahul Bedarkar Signed-off-by: Peter Korsgaard

core/pkg-generic: call MESSAGE when saving package legal-info

2017-07-03T15:34:34+00:00

Currently, the per-package legal-info is mostly silent, but we're soon to add a check for the hashes of the license files. In that case, and when there is a hash mis-match, we want a user to know what package had a changed license file. So, we add a call to MESSAGE to display the package we're currently saving the legal-info of, like so: >>> busybox 1.26.2 Collecting legal info Signed-off-by: "Yann E. MORIN" Cc: Luca Ceresoli Cc: Peter Korsgaard Cc: Rahul Bedarkar Signed-off-by: Peter Korsgaard

core/download: fix source check for git method

2017-05-13T13:08:41+00:00

Running foo-source-check on packages retrieved from git fails. This is because there is no associated stamp file, so we do not have a rule-assignment that sets PKG for foo-source-check. But it does not make sense to have a stamp file at all, because source-check is not supposed to change anything: the status after is exactly the same as before; nothing is downlaoded, so there is no progress (whatsoever) to memorise. Fix that by just defining PKG in the source-check rule definition. Fixes #9796. Reported-by: Thomas Petazzoni Signed-off-by: "Yann E. MORIN" Cc: Thomas Petazzoni Signed-off-by: Thomas Petazzoni

core: add rule to dump packages' build order

2017-04-13T21:09:08+00:00

When debugging hidden dependencies, the build order is very important. Most notably, it is interesting to identify potential culprits. Add a new top-level rule, show-biuld-order, that dumps all the packages in the order they would get built. Note that there are a few differences with show-targets: - more packages are reported, becasue show-targets does not report host packages that have no prompt; - the output is line-based, because we're using $(info $(1)); getting a single output line like show-targets would require we use an actual command, like printf '%s ' $(1); but that takes a lot of time, while $(info $(1)) is almost instantaneous (the time to parse the Makefiles); - rootfs targets are not reported. Signed-off-by: "Yann E. MORIN" Cc: Thomas Petazzoni Cc: Arnout Vandecappelle Cc: Peter Korsgaard Reviewed-by: Arnout Vandecappelle (Essensium/Mind) Acked-by: Arnout Vandecappelle (Essensium/Mind) Signed-off-by: Thomas Petazzoni

arch, linux, package: remove whitespaces

2017-03-29T21:30:37+00:00

Whitespaces were searched using the following regex: [ ]{1,}\t and then manually removed in most of the cases. For xserver_xorg-server.mk, tabs before backslashes were removed. Signed-off-by: Bernd Kuhls Signed-off-by: Thomas Petazzoni

Makefile: add check of binaries architecture

2017-03-20T21:22:22+00:00

As shown recently by the firejail example, it is easy to miss that a package builds and installs binaries without actually cross-compiling them: they are built for the host architecture instead of the target architecture. This commit adds a small helper script, check-bin-arch, called as a GLOBAL_INSTRUMENTATION_HOOKS at the end of the target installation of each package, to verify that the files installed by this package have been built for the correct architecture. Being called as a GLOBAL_INSTRUMENTATION_HOOKS allows the build to error out right after the installation of the faulty package, and therefore get autobuilder error detection properly assigned to this specific package. Example output with the firejail package enabled, when building for an ARM target: ERROR: architecture for ./usr/lib/firejail/libconnect.so is Advanced Micro Devices X86-64, should be ARM ERROR: architecture for ./usr/bin/firejail is Advanced Micro Devices X86-64, should be ARM ERROR: architecture for ./usr/lib/firejail/libtrace.so is Advanced Micro Devices X86-64, should be ARM ERROR: architecture for ./usr/lib/firejail/libtracelog.so is Advanced Micro Devices X86-64, should be ARM ERROR: architecture for ./usr/lib/firejail/ftee is Advanced Micro Devices X86-64, should be ARM ERROR: architecture for ./usr/lib/firejail/faudit is Advanced Micro Devices X86-64, should be ARM ERROR: architecture for ./usr/bin/firemon is Advanced Micro Devices X86-64, should be ARM ERROR: architecture for ./usr/bin/firecfg is Advanced Micro Devices X86-64, should be ARM Many thanks to Yann E. Morin and Arnout Vandecappelle for their reviews and suggestions. Signed-off-by: Thomas Petazzoni