buildroot/package/ncurses, branch 2017.02

ncurses: remove BR2_PACKAGE_NCURSES_TARGET_{FORM, MENU, PANEL} options

2017-02-26T16:00:12+00:00

The ncurses sub-options BR2_PACKAGE_NCURSES_TARGET_{FORM,MENU,PANEL} are currently very badly broken: they only control whether the libform, libmenu and libpanel libraries are installed in $(TARGET_DIR), but do absolutely nothing about their installation in $(STAGING_DIR). This means that when one of those options is disabled, the corresponding library is indeed not installed in the target, but is available in staging. It can therefore be detected by the configure script of another package and used... even though the library will not be in the target, causing a runtime failure. Internally, ncurses.mk uses the "make install" logic of ncurses for the staging installation, but uses a completely hand-written logic for the target installation, which is the reason for this desynchronization between what's installed in staging and target. When BR2_PACKAGE_NCURSES_WCHAR=y, this also causes some build failures. Indeed, when BR2_PACKAGE_NCURSES_WCHAR=y, Buildroot creates some symbolic links lib.so -> libw.so in staging and target, but only for the lib that have been enabled by BR2_PACKAGE_NCURSES_TARGET_{FORM,MENU,PANEL}. Due to this, a package that for example needed the libmenu library but forgot to select BR2_PACKAGE_NCURSES_TARGET_MENU was: - Building fine with BR2_PACKAGE_NCURSES_WCHAR disabled (because libmenu.so exists in staging), but would fail to run at runtime because libmenu.so is not in the target. - Fail to build with BR2_PACKAGE_NCURSES_WCHAR=y because only libmenuw.so exists, and not the libmenu.so symbolic link. Since those libraries are small (43K for libform, 21K for libmenu and 8.2K for libpanel), this commit takes the very simple approach of removing those options, and installing the libraries unconditionally. It therefore uses the "make install" logic for both the staging *and* target installation. In detail, this commit: - Removes the NCURSES_PROGS variable, not needed since --without-progs already allows to disable the build and installation of programs. - Removes the NCURSES_LIBS-y variable, and replaces it with a single unconditional assignement to NCURSES_LIBS, only used to create the libw.so -> lib.so symbolic links when wchar support is enabled. - Removes NCURSES_INSTALL_TARGET_CMDS and the functions it was calling: NCURSES_INSTALL_TARGET_LIBS and NCURSES_INSTALL_TARGET_PROGS. - Adds a NCURSES_TARGET_SYMLINK_RESET hook to create the reset -> tset symbolic link, as was done before. - Adds a NCURSES_TARGET_CLEANUP_TERMINFO to cleanup the terminfo files in the target, so that we stay in the same situation in terms of installed terminfo files. - Removes the BR2_PACKAGE_NCURSES_TARGET_{FORM,MENU,PANEL} options from the Config.in files: both their definition and usage. - Simplifies all the symlink dance for lib -> libw, because as Yann E. Morin suggested, this dance is only needed in staging, not in the target. Once binaries have been built, they refer to the SONAME of the library, which is the libw variant (for shared linking). For static linking and .pc files, it's obvious that we don't care about them on the target. Therefore the NCURSES_LINK_LIBS_STATIC, NCURSES_LINK_LIBS_SHARED and NCURSES_LINK_PC functions no longer take any argument: they always apply to STAGING_DIR only. NCURSES_LINK_TARGET_LIBS is removed. It is worth mentioning that adding Config.in.legacy support is *NOT* necessary. Indeed: - If they were disabled before this patch, having them in Config.in.legacy would not trigger the legacy warning. - If they were enabled before this patch, then the behavior is unchanged: all libraries are now unconditionally installed. So there is no point in warning the user. We double-checked the installed size of a filesystem containing just ncurses before and after this patch, and the only folder that has its size changed is /usr/lib, growing from 852 KB to 932 KB in the wchar enabled case. That's a 80 KB system size increase. This commit fixes the sngrep build failure and potentially numerous runtime issues with ncurses. Fixes: http://autobuild.buildroot.net/results/7b5db21a6c568e6c6c8fe2b5d5a2f5ca24df510c/ Signed-off-by: Thomas Petazzoni

ncurses: use $(HOST_MAKE_ENV) when calling $(MAKE)

2016-10-22T13:19:24+00:00

Signed-off-by: Gustavo Zacarias Reviewed-by: Arnout Vandecappelle (Essensium/Mind) Signed-off-by: Thomas Petazzoni

ncurses: use $(TARGET_MAKE_ENV) when calling $(MAKE)

2016-10-15T12:17:00+00:00

Signed-off-by: Gustavo Zacarias Reviewed-by: Arnout Vandecappelle (Essensium/Mind) Signed-off-by: Thomas Petazzoni

package/ncurses: fix build on noMMU uclinux targets

2016-08-21T20:20:57+00:00

The ncurses buildsystem does not recognise 'uclinux' as being a 'linux', so it falls back to generic checks, especially when trying to decide what macros to define. So it misses defining absolutely required macros when doing widechar, which break the bui,d. But 'uclinux' is just a 'linux' like any other in this respect. We fix both aclocal.m4 and the generated ./configure script because ncurses does not autoreconf correctly (see comment in 0001-*.patch). Fixes: http://autobuild.buildroot.org/results/d5c/d5c787d34acbfc0c0c7bd8cc0e15b5bc2460d88a/ http://autobuild.buildroot.org/results/fc4/fc4b41fb955c390913a879e0202760347ce29987/ [...too many to list...] Signed-off-by: "Yann E. MORIN" Cc: Waldemar Brodkorb Signed-off-by: Thomas Petazzoni

ncurses: reinstall l/linux terminfo file

2016-08-05T12:21:31+00:00

This file was installed prior to the refactoring done in commit 33ba5188351ece027455e460f6cba4245af49f3a ("ncurses: factorize terminfo files installation"). Reported-by: Benoît Allard Signed-off-by: Thomas Petazzoni

ncurses: use foreach make loops instead of shell for loops

2016-08-03T20:52:42+00:00

The main benefit of using make foreach loops is that they will abort if one of the iteration of the loop fails. The current for loops will continue, and only report a failure if the last iteration was a failure, but will silently ignore other errors. Signed-off-by: Thomas Petazzoni Reviewed-by: Matt Weber Signed-off-by: Peter Korsgaard

ncurses: factorize terminfo files installation

2016-08-03T20:52:24+00:00

This long list of commands to copy the terminfo files from staging to target is really silly and can be factorized using a NCURSES_TERMINFO_FILES variable, which is then iterated through. Signed-off-by: Thomas Petazzoni Reviewed-by: Matt Weber Signed-off-by: Peter Korsgaard

ncurses: install PuTTY terminfo files

2016-08-02T20:15:41+00:00

Signed-off-by: David Glessner Signed-off-by: Matt Weber Signed-off-by: Thomas Petazzoni

ncurses: remove empty host dependencies definition

2016-07-03T08:24:02+00:00

Signed-off-by: Julien Floret Signed-off-by: Thomas Petazzoni

ncurses: fix gcc 5 compile issue for real

2015-07-26T16:46:33+00:00

The previous patch didn't work in all cases. The new patch is taken from upstream: http://ncurses.scripts.mit.edu/?p=ncurses.git;a=commit;h=97bb4678dc03e753290b39bbff30ba2825df9517 Fetch from: http://ncurses.scripts.mit.edu/?p=ncurses.git;a=blobdiff;f=ncurses/base/MKlib_gen.sh;h=b91398c740a266f10edbbce19f19c52b9709556f;hp=d8cc3c9751faa157d0c8cb8e16fbe4217703966b;hb=97bb4678dc03e753290b39bbff30ba2825df9517;hpb=762520a7930d7f698d542628d3c04bc201f7dac2 [Thomas: - removed Signed-off-by in the Buildroot commit from the ncurses author: the ncurses author never submitted this patch to Buildroot. - fixed the Author of the Buildroot commit, it was still "kyak" - added a description + Signed-off-by in the patch itself.] Signed-off-by: Mikhail Peselnik Acked-by: Jaap Crezee Tested-by: Jaap Crezee Reviewed-by: "Yann E. MORIN" Signed-off-by: Thomas Petazzoni