buildroot/package/lmbench, branch 2016.02

packages: use backtick instead of $(shell ...) make function

2015-07-14T22:42:01+00:00

It is often difficult to know exactly when make will expand the variable, and usually it can only be expanded after the dependencies have been built (e.g. pkg-config or the .pc file). Using a backtick instead makes it very clear that it will be expanded only while executing the command. This change is useful for two cases: 1. The per-package staging (and host) directory will be created as part of the configure step, so any $(shell ...) variable that is used in the configure step will fail because the directory doesn't exist yet. 2. 'make printvars' evaluates the variables it prints. It will therefore trigger a lot of errors from missing .pc files and others. The backticks, on the other hand, are not expanded, so with this change the output of 'make printvars' becomes clean again. This commit contains only the easy changes: replace $(shell ...) with `...`, and also replace ' with " where needed. Follow-up commits will tackle the more complicated cases that need additional explanation. After this change, the following instances of $(shell ...) will remain: - All assignments that use := - All variables that are used in make conditionals (which don't expand the backticks). - All variables that only refer to system executables and make variables that don't change. - The calls to check-host-* in dependencies.mk, because it is eval'ed. [Original patch by Fabio Porcedda, but extended quite a bit by Arnout.] Signed-off-by: Fabio Porcedda Signed-off-by: Arnout Vandecappelle (Essensium/Mind) Signed-off-by: Thomas Petazzoni

lmbench: fix build with libtirpc

2015-03-06T11:55:44+00:00

When linking with an external libtirpc, -ltirpc must come after lmbench.a in the linker command line. Use LDLIBS for that. Fixes: http://autobuild.buildroot.net/results/89e/89ee35561d3a49f38e9a747ed78a5846be4764c8/ http://autobuild.buildroot.net/results/409/4097b1c2585db2de517a8741174c02177aabee00/ and more. Also, remove LMBENCH_LDLIBS assignment. This variable was not used before. Reviewed-by: Fabio Porcedda Tested-by: Fabio Porcedda Signed-off-by: Baruch Siach Signed-off-by: Thomas Petazzoni

lmbench: use pkg-config to find libtirpc

2015-02-14T21:11:45+00:00

Signed-off-by: Fabio Porcedda Signed-off-by: Thomas Petazzoni

package: add hashes for SourceForge-hosted packages

2014-12-28T21:21:16+00:00

Since SourceForge sometimes serves us faulty tarballs, we can tons of autobuild failures: http://autobuild.buildroot.org/results/9fb/9fba5bf086a4e7a29e5f7156ec43847db7aacfc4/ http://autobuild.buildroot.org/results/6c8/6c837b244c45ac3b3a887734a371cd6d226cf216/ ... Fix that by adding hash files for all SourceForge-hosted packages (thos etht did not already have it). We normally prefer to use hashes published by upstream, but hunting them all one by one is a tedious task, so those hashes were all locally computed with a script that searched for SF-hosted packages, downloades the associated tarball, computed the hash, and stored it in the corresponding .hash file. Also, SF publishes sha1 hashes, while I used the stronger sha256, since sha1 is now considered to be relatively weak. Signed-off-by: "Yann E. MORIN" Cc: Peter Korsgaard Cc: Thomas Petazzoni Cc: Maxime Hadjinlian Cc: Richard Braun Cc: Nathaniel Roach Signed-off-by: Thomas Petazzoni

.mk files: bulk aligment and whitespace cleanup of assignments

2014-10-07T13:00:28+00:00

The Buildroot coding style defines one space around make assignments and does not align the assignment symbols. This patch does a bulk fix of offending packages. The package infrastructures (or more in general assignments to calculated variable names, like $(2)_FOO) are not touched. Alignment of line continuation characters (\) is kept as-is. The sed command used to do this replacement is: find * -name "*.mk" | xargs sed -i \ -e 's#^$[A-Z0-9a-z_]\+$\s*$[?:+]\?=$\s*$#\1 \2#' -e 's#^$[A-Z0-9a-z_]\+$\s*$[?:+]\?=$\s*$[^\\]\+$$#\1 \2 \3#' -e 's#^$[A-Z0-9a-z_]\+$\s*$[?:+]\?=$\s*$[^\\ \t]\+\s*\\$\s*$#\1 \2 \3#' -e 's#^$[A-Z0-9a-z_]\+$\s*$[?:+]\?=$$\s*\\$#\1 \2\3#' Brief explanation of this command: ^$[A-Z0-9a-z_]\+$ a regular variable at the beginning of the line $[?:+]\?=$ any assignment character =, :=, ?=, += $[^\\]\+$ any string not containing a line continuation $[^\\ \t]\+\s*\\$ string, optional whitespace, followed by a line continuation character $\s*\\$ optional whitespace, followed by a line continuation character Hence, the first subexpression handles empty assignments, the second handles regular assignments, the third handles regular assignments with line continuation, and the fourth empty assignments with line continuation. This expression was tested on following test text: (initial tab not included) FOO = spaces before FOO = spaces before and after FOO = tab before FOO = tab and spaces before FOO = tab after FOO = tab and spaces after FOO = spaces and tab after FOO = \ FOO = bar \ FOO = bar space \ FOO = \ GENIMAGE_DEPENDENCIES = host-pkgconf libconfuse FOO += spaces before FOO ?= spaces before and after FOO := FOO = FOO = FOO = FOO = $(MAKE1) CROSS_COMPILE=$(TARGET_CROSS) -C AT91BOOTSTRAP3_DEFCONFIG = \ AXEL_DISABLE_I18N=--i18n=0 After this bulk change, following manual fixups were done: - fix line continuation alignment in cegui06 and spice (the sed expression leaves the number of whitespace between the value and line continuation character intact, but the whitespace before that could have changed, causing misalignment. - qt5base was reverted, as this package uses extensive alignment which actually makes the code more readable. Finally, the end result was manually reviewed. Signed-off-by: Thomas De Schampheleire Cc: Yann E. Morin Cc: Thomas Petazzoni Signed-off-by: Peter Korsgaard

package: remove the trailing slash sign from _SITE variable

2014-07-31T21:17:46+00:00

Since the trailing slash is stripped from $($(PKG)_SITE) by pkg-generic.mk: $(call DOWNLOAD,$($(PKG)_SITE:/=)/$($(PKG)_SOURCE)) so it is redundant. This patch removes it from $(PKG)_SITE variable for BR consistency. Signed-off-by: Jerzy Grzegorek Signed-off-by: Thomas Petazzoni

Revert "lmbench: fix build for xtensa"

2014-04-03T19:36:38+00:00

This reverts commit 7c04932603476f3adf474f3bc47c35bdb59d947a. Now that -mtext-section-literals is specified in the xtensa ABI this fix is no longer needed. Signed-off-by: Max Filippov Signed-off-by: Thomas Petazzoni

lmbench: fix build for xtensa

2013-12-31T10:57:51+00:00

The lmbench package generates a binary that is too large for the xtensa default placement of literals in a dedicated section. Use -mtext-section-literal to place literals in the text section. Fixes http://autobuild.buildroot.net/results/afe/afe9f4550e6ac9a41e4ba338773c1d51034273f7/. Signed-off-by: Baruch Siach Signed-off-by: Thomas Petazzoni

packages: remove package clean commands

2013-12-08T18:42:34+00:00

Signed-off-by: Thomas De Schampheleire Signed-off-by: Peter Korsgaard

Config.in files: add missing dependencies to toolchain option comments

2013-11-10T22:59:57+00:00

When a package A depends on config option B and toolchain option C, then the comment that is given when C is not fulfilled should also depend on B. For example: config BR2_PACKAGE_A depends on BR2_B depends on BR2_LARGEFILE depends on BR2_WCHAR comment "A needs a toolchain w/ largefile, wchar" depends on !BR2_LARGEFILE || !BR2_WCHAR This comment should actually be: comment "A needs a toolchain w/ largefile, wchar" depends on BR2_B depends on !BR2_LARGEFILE || !BR2_WCHAR or if possible (typically when B is a package config option declared in that same Config.in file): if BR2_B comment "A needs a toolchain w/ largefile, wchar" depends on !BR2_LARGEFILE || !BR2_WCHAR [other config options depending on B] endif Otherwise, the comment would be visible even though the other dependencies are not met. This patch adds such missing dependencies, and changes existing such dependencies from depends on BR2_BASE_DEP && !BR2_TOOLCHAIN_USES_GLIBC to depends on BR2_BASE_DEP depends on !BR2_TOOLCHAIN_USES_GLIBC so that (positive) base dependencies are separate from the (negative) toolchain dependencies. This strategy makes it easier to write such comments (because one can simply copy the base dependency from the actual package config option), but also avoids complex and long boolean expressions. Signed-off-by: Thomas De Schampheleire Acked-by: Arnout Vandecappelle (Essensium/Mind) (untested) Signed-off-by: Peter Korsgaard