buildroot/fs/common.mk, branch 2015.11.1

fs/common: add _POST_GEN_HOOKS support

2015-08-10T18:56:05+00:00

The common filesystem infrastructure already supports a _PRE_GEN_HOOKS variable, which allows filesystem makefiles to register some actions to be done before the root filesystem image is generated. This commit adds a similiar _POST_GEN_HOOKS variable, which will allow filesystem makefiles to do some actions after the filesystem image has been generated. It will initially be used by the iso9660 filesystem to delete the temporary directory it creates. Signed-off-by: Thomas Petazzoni Signed-off-by: Noé Rubinstein Acked-by: "Yann E. MORIN" Signed-off-by: Thomas Petazzoni

fs: build host-mkpasswd when BR2_ROOTFS_USERS_TABLES is used

2015-07-21T21:12:52+00:00

The code in fs/common.mk properly triggers the build of host-mkpasswd when at least one package specifies a _USERS variable. However, when no selected package specifies a _USERS variable but the user uses a custom users table through BR2_ROOTFS_USERS_TABLES, then we forget to build host-mkpasswd, leading to build failures if you don't have mkpasswd installed in your machine. This commit fixes that by taking into account both the package users table and the custom users table when deciding to depend or not on host-mkpasswd. Reported-by: Auke Willem Oosterhoff Cc: Auke Willem Oosterhoff Cc: Yann E. MORIN Signed-off-by: Thomas Petazzoni Acked-by: "Yann E. MORIN"

fs: only add non rootfs- targets to PACKAGES

2015-04-26T10:16:19+00:00

Commit 4570dbcb14b394d8f3c97baf4c9e5f4f225d1d37 ("4570dbcb14b394d8f3c97baf4c9e5f4f225d1d37") added the dependencies of rootfs building logic to PACKAGES, only thinking about the case where rootfs building logic actually depends on real, normal packages (host-mtd, host-genext2fs, etc.). But some file systems (rootfs-ubi) depend on other filesystem images (rootfs-ubifs). And such targets should not be added to PACKAGES, otherwise an incorrect circular dependency is created. This commit fixes that by only adding the rootfs building logic dependencies that do *not* start with rootfs- to the global PACKAGES variable. Signed-off-by: Thomas Petazzoni Reviewed-by: "Yann E. MORIN"

fs: add rootfs dependencies to PACKAGES

2015-04-14T08:17:04+00:00

The logic for creating most of the filesystem images requires a certain number of host packages to be built. However, those packages are not currently listed in the global PACKAGES variables, and they are not dependencies of any other package listed in the PACKAGES variable. While it does not have any practical implications, it makes sense to have those packages listed in the global PACKAGES variable, which this commit implements. Signed-off-by: Thomas Petazzoni Acked-by: "Yann E. MORIN"

fs: declare phony targets as such

2015-04-14T08:12:32+00:00

This commit improves the filesystem handling code to declare its various targets as PHONY when appropriate. Signed-off-by: Thomas Petazzoni Reviewed-by: "Yann E. MORIN"

fs/common: build host-xz when xz compression is used

2015-03-09T13:10:13+00:00

When a filesystem image is xz-compressed, the XZ variable is used to refer to the xz compression tool, but it is not necessarily available. Add a proper dependency to fix that. Signed-off-by: Thomas De Schampheleire Signed-off-by: Thomas Petazzoni

fs: Bail out on errors in fakeroot script

2015-03-08T21:21:36+00:00

Currently, the generated fakeroot script has no error checking causing make to continue building even if some of the fakeroot script commands have failed. This can cause e.g. using an invalid device tables to go unnoticed. So add a "set -e" to the start of the fakeroot script so it will exit with a failure code as soon as one of the script commands fails. Signed-off-by: Stefan Sørensen Acked-by: "Yann E. MORIN" Signed-off-by: Thomas Petazzoni

package: indentation cleanup

2014-12-10T20:53:30+00:00

Signed-off-by: Jerzy Grzegorek Signed-off-by: Thomas Petazzoni

package: indentation cleanup

2014-10-26T04:47:05+00:00

Signed-off-by: Jerzy Grzegorek Signed-off-by: Peter Korsgaard

infra: consistently use double dollar signs inside inner-xxx-targets

2014-06-14T17:09:54+00:00

The inner-xxx-targets in the buildroot package infrastructures are evaluated using $(eval) which causes variable references to be a bit different than in regular make code. As we want most references to be expanded only at the time of the $(eval) we should not use standard references $(VAR) but rather use double dollar signs $$(VAR). This includes function references like $(call), $(subst), etc. The only exception is the reference to pkgdir/pkgname and numbered variables, which are parameters to the inner block: $(1), $(2), etc. This patch introduces consistent usage of double-dollar signs throughout the different inner-xxx-targets blocks. In some cases, this would potentially cause circular references, in particular when the value of HOST_FOO_VAR would be obtained from the corresponding FOO_VAR if HOST_FOO_VAR is not defined. In these cases, a test is added to check for a host package (the only case where such constructions are relevant; these are not circular). Benefits of these changes are: - behavior of variables is now again as expected. For example, setting $(2)_VERSION = virtual in pkg-virtual.mk will effectively work, while originally it would cause very odd results. - The output of 'make printvars' is now much more useful. This target shows the value of all variables, and the expression that led to that value. However, if the expression was coming from an inner-xxx-targets block, and was using single dollar signs, it would show in printvars as VAR = value (value) while if double dollar signs are used, it would effectively look like VAR = value (actual expression) as is intended. This improvement is for example effective for FOO_DL_VERSION, FOO_RAWNAME, FOO_SITE_METHOD and FOO_MAKE. The correctness of this patch has been verified using 'make printvars', 'make manual' and 'make legal-info' before and after applying this patch, and comparing the output. Insight-provided-by: Arnout Vandecappelle Signed-off-by: Thomas De Schampheleire Signed-off-by: Thomas Petazzoni