bmcweb/redfish-core/src, branch master

Fix response error code for error - Unauthorized

2019-12-06T17:18:04+00:00

Tested by: Request: Creating session with wrong credential. curl --insecure -X POST -D headers.txt https://${BMC_IP}/redfish/v1/SessionService/Sessions -d '{"UserName":"root", "Password":"penBmc"}' Resonse Error code: HTTP/1.1 401 Unauthorized Signed-off-by: Sunitha Harish Change-Id: I9c7b0af644f1e3d987b4f76e4206bbb276aba035

Add "Retry-After" header for temporarily unavailable messages

2019-12-02T16:53:55+00:00

Whenever the Redfish response is that a service is temporarily unavailable, the "Retry-After" header is added with the same value, so just set the header automatically with the response. Tested: Confirmed that the "Retry-After" header is set correctly with the Redfish temporarily unavailable message. Change-Id: I9c940be94d9d284b9633c5caa2ce71ade76d22d5 Signed-off-by: Jason M. Bills

Make references to crow less obvious

2019-10-18T16:20:11+00:00

Recently, a number of people in the community have made the (admittedly easy) mistake that we use a significant portion of crow. Today, we use crow for the router, and the "app" structure, and even those have been significantly modified to meet the bmc needs. All other components have been replaced with Boost beast. This commit removes the crow mentions from the Readme, and moves the crow folder to "http" to camouflage it a little. No code content has changed. Tested: Code compiles. No functional change made to any executable code. Signed-off-by: Ed Tanous Change-Id: Iceb57b26306cc8bdcfc77f3874246338864fd118

Remove a lame clang-format off

2019-09-18T20:08:20+00:00

Code was tabbed into the wrong spot as a result of shutting clang-format off for a dubious reason. Turn it back on. Tested: It builds. Only whitespace changes present Signed-off-by: Ed Tanous Change-Id: I08b294ca5ea076f8cb5680b801b507127e091824

Fix variable name case style for CI warning

2019-06-28T18:26:34+00:00

CI gives a warning for invalid case style in variable names. This fixes the warnings that show up so far. Change-Id: I2a8706d3283bdc685dc026391de715accea7b86e Signed-off-by: Jason M. Bills

Don't set result to success when calling success

2019-03-01T20:47:48+00:00

res.success is the default, if one async call sets failure, and another later sets success, we don't want to overwrite the failure with sucess. Tested-by: still got success on good patch Change-Id: Iee76892f7517d508ed98929d9ecd127dd83b1329 Signed-off-by: James Feist

Add MessageArgs for Redfish messages from the Base registry

2018-11-19T03:45:01+00:00

Per the Redfish API Specification, the MessageArgs array of strings is required when using a MessageId for a parameterized message. This change adds the MessageArgs array for the Redfish messages that we use from the Base message registry. Tested: Manually set various error types and confirmed that the MessageArg array was properly displayed. Change-Id: I2248128f8290305ba3466ef2ce57447ce970a57d Signed-off-by: Jason M. Bills

Simplify Redfish error message property interface

2018-11-15T19:47:50+00:00

The error message code used a json_pointer object which must begin with a '/' character and had to be sent as an extra parameter. This change simplifies the interface by using a string so there doesn't have to be a '/'. This allowed the same property argument passed for the message to be used for the property field path. Tested: Sent an error with a property and verified that it is correctly displayed. Change-Id: I0571e2eee627cedf29d751588a4f1bceee66f084 Signed-off-by: Jason M. Bills

Update Redfish to Base.1.4.0 message registry

2018-10-31T20:22:32+00:00

Update the Redfish error_messages from Base.1.2.0 to Base.1.4.0 from the Redfish standard registries. Change-Id: I771b119372fd995bd1dc4065830485b6a848f086 Signed-off-by: Jason M. Bills

Update formatting of error string literals and message descriptions

2018-10-31T20:22:26+00:00

clang-format doesn't automatically merge multi-line string literals, so this change updates the formatting to merge some multi-line strings into fewer lines. This change also corrects the numbering in the error message descriptions to match the function parameter numbers. Change-Id: Ibedcaf5793a607acacdb3bc83081599ba508c989 Signed-off-by: Jason M. Bills