libc: Remove NULL check for format argument in snprintf()

2016-07-18T06:04:17+00:00

libc printf style functions are annotated with __attribute__((format (printf, x, y))) which causes GCC to perform compile time checks against these arguments. As of at least gcc 6.1.1 [(GCC) 6.1.1 20160602] this causes an error running make check. GCC appears to be guaranteeing that the format argument won't be NULL and complaining about explicit checks. In file included from core/test/run-console-log-buf-overrun.c:48:0: core/test/run-console-log-buf-overrun.c: In function ‘snprintf’: core/test/../../libc/stdio/snprintf.c:21:19: error: nonnull argument ‘format’compared to NULL [-Werror=nonnull-compare] if ((buff==NULL) || (format==NULL)) ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make: *** [core/test/Makefile.check:59:core/test/run-console-log-buf-overrun] Error 1 Signed-off-by: Cyril Bur Signed-off-by: Stewart Smith

Initial commit of Open Source release

2014-07-02T05:36:20+00:00

Signed-off-by: Benjamin Herrenschmidt

blackbird-skiboot/libc/stdio/snprintf.c, branch 04-16-2019

libc: Remove NULL check for format argument in snprintf()

Initial commit of Open Source release