From 2a98dbbcd72cfae508c4d90bcbdc829363554ea7 Mon Sep 17 00:00:00 2001 From: Wei Yongjun Date: Tue, 18 Jun 2013 12:21:21 +0800 Subject: usb: gadget: f_ecm: fix missing unlock on error in ecm_alloc() Add the missing unlock before return from function ecm_alloc() in the error handling case. Introduced by commit da92801c647cdebfd45001fd6aaecb8f0be7f56b. (usb: gadget: f_ecm: add configfs support) Signed-off-by: Wei Yongjun Acked-by: Andrzej Pietrasiewicz Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/f_ecm.c | 1 + 1 file changed, 1 insertion(+) (limited to 'drivers/usb') diff --git a/drivers/usb/gadget/f_ecm.c b/drivers/usb/gadget/f_ecm.c index fcafe1af4585..5d3561ea1c15 100644 --- a/drivers/usb/gadget/f_ecm.c +++ b/drivers/usb/gadget/f_ecm.c @@ -1012,6 +1012,7 @@ struct usb_function *ecm_alloc(struct usb_function_instance *fi) sizeof(ecm->ethaddr)); if (status < 12) { kfree(ecm); + mutex_unlock(&opts->lock); return ERR_PTR(-EINVAL); } ecm_string_defs[1].s = ecm->ethaddr; -- cgit v1.2.1