From 7eb8d508b5cfabbb147670ee063438469d94c465 Mon Sep 17 00:00:00 2001 From: Jean Delvare Date: Thu, 28 Oct 2010 20:31:47 +0200 Subject: hwmon: (w83795) Fix parity checks x % 1 is obviously wrong, as it always evaluates to 0. You want x % 2, or x & 1, for parity checking. Signed-off-by: Jean Delvare --- drivers/hwmon/w83795.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'drivers/hwmon') diff --git a/drivers/hwmon/w83795.c b/drivers/hwmon/w83795.c index 71b7a254beeb..ec8a1d1f7d79 100644 --- a/drivers/hwmon/w83795.c +++ b/drivers/hwmon/w83795.c @@ -183,7 +183,7 @@ static const u8 IN_LSB_SHIFT_IDX[][2] = { #define W83795_REG_FAN_MIN_HL(index) (0xB6 + (index)) #define W83795_REG_FAN_MIN_LSB(index) (0xC4 + (index) / 2) #define W83795_REG_FAN_MIN_LSB_SHIFT(index) \ - (((index) % 1) ? 4 : 0) + (((index) & 1) ? 4 : 0) #define W83795_REG_VID_CTRL 0x6A @@ -670,7 +670,7 @@ store_fan_min(struct device *dev, struct device_attribute *attr, data->fan_min[index] = val; w83795_write(client, W83795_REG_FAN_MIN_HL(index), (val >> 4) & 0xff); val &= 0x0f; - if (index % 1) { + if (index & 1) { val <<= 4; val |= w83795_read(client, W83795_REG_FAN_MIN_LSB(index)) & 0x0f; @@ -823,7 +823,7 @@ show_temp_src(struct device *dev, struct device_attribute *attr, char *buf) u8 val = index / 2; u8 tmp = data->temp_src[val]; - if (index % 1) + if (index & 1) val = 4; else val = 0; @@ -850,7 +850,7 @@ store_temp_src(struct device *dev, struct device_attribute *attr, tmp = SENSORS_LIMIT(tmp, 0, 15); mutex_lock(&data->update_lock); - if (index % 1) { + if (index & 1) { tmp <<= 4; data->temp_src[val] &= 0x0f; } else { -- cgit v1.2.1