summaryrefslogtreecommitdiffstats
path: root/drivers/scsi
Commit message (Collapse)AuthorAgeFilesLines
* [PATCH] libata: clear sdev->locked on door lock failureTejun Heo2006-08-091-0/+13
| | | | | | | | | | | | | | SCSI EH locks door if sdev->locked is set. Sometimes door lock command fails continuously (e.g. when medium is not present) and as libata uses EH to acquire sense data, this easily creates a loop where a failed lock door invokes EH and EH issues lock door on completion. This patch clears sdev->locked on door lock failure to break this loop. This problem has been spotted and diagnosed by Unicorn Chang <uchang@tw.ibm.com>. Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>
* [PATCH] Fix compile problem when sata debugging is onKeith Owens2006-08-091-2/+2
| | | | | | | Fix a sata debug print statement that still uses an old variable name. Signed-off-by: Keith Owens <kaos@ocs.com.au> Signed-off-by: Jeff Garzik <jeff@garzik.org>
* [PATCH] libata: fix ata_device_add() error pathTejun Heo2006-08-051-4/+4
| | | | | | | | | | | | | | | | In the error path, ata_device_add() * dereferences null host_set->ports[] element. * calls scsi_remove_host() on not-yet-added shost. This patch fixes both bugs. The first problem was spotted and initial patch submitted by Dave Jones <davej@redhat.com>. The second problem was mentioned and fixed by Jeff Garzik <jgarzik@pobox.com> in a larger cleanup patch. Cc: Dave Jones <davej@redhat.com> Cc: Jeff Garzik <jgarzik@pobox.com> Signed-off-by: Tejun Heo <htejun@gmail.com>
* [PATCH] [libata] manually inline ata_host_remove()Jeff Garzik2006-08-051-25/+6
| | | | | | | (tj: this is for the following ata_device_add() fix) Signed-off-by: Jeff Garzik <jeff@garzik.org> Signed-off-by: Tejun Heo <htejun@gmail.com>
* [PATCH] sata_sil24: don't set probe_ent->mmio_baseTejun Heo2006-08-051-1/+0
| | | | | | | | sata_sil24 doesn't make use of probe_ent->mmio_base and setting this field causes the area to be released twice on detach. Don't set probe_ent->mmio_base. Signed-off-by: Tejun Heo <htejun@gmail.com>
* [PATCH] ata_piix: fix host_set private_data intializationTejun Heo2006-08-051-0/+1
| | | | | | | | To get host_set->private_data initialized reliably, all pinfos need to point to the same hpriv. Restore pinfo->private_data after pata pinfo assignment. Signed-off-by: Tejun Heo <htejun@gmail.com>
* [PATCH] libata: fix ata_port_detach() for old EH portsTejun Heo2006-08-051-1/+2
| | | | | | | | | ata_prot_detach() did nothing for old EH ports and thus SCSI hosts associated with those ports are left dangling after they are detached leaving stale devices and causing oops eventually. Make ata_port_detach() remove SCSI hosts for old EH ports. Signed-off-by: Tejun Heo <htejun@gmail.com>
* [PATCH] ahci: skip protocol test altogether in spurious interrupt codeUnicorn Chang2006-08-031-8/+2
| | | | | | | | Skip protocol test altogether in spurious interrupt code. If PIOS is received when it shouldn't, ahci will raise protocol violation. Signed-off-by: Unicorn Chang <uchang@tw.ibm.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>
* kbuild: hardcode value of YACC&LEX for aic7-triple-xSam Ravnborg2006-08-011-0/+2
| | | | | | | When we introduced -rR then aic7xxx no loger could pick up definition of YACC&LEX from make - so do it explicit now. Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
* Merge branch 'master' into upstream-fixesJeff Garzik2006-07-294-24/+11
|\
| * [PATCH] scsi: kill overeager "not-ready" messagesJens Axboe2006-07-281-4/+1
| | | | | | | | | | | | | | | | HAL and friends have a tendency to trigger this one all the time. It's not really interesting, so kill it. The vendor kernels all do anyways. Signed-off-by: Jens Axboe <axboe@suse.de>
| * [PATCH] fix compile regression for a few scsi driversChristoph Hellwig2006-07-262-12/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes three drivers to compile again after my patch that removes the data_cmnd member from struct scsi_cmnd. The fas216 change is trivial, it should have been using ->cmnd all the time. NCR53C9 (which seem to be mostly duplicate driver with esp.c!) is doing something odd, it should only have looked at ->cmnd before not the saved copy that is kept for the error handlers sake. Note that it really should deal with the sync setting themselves but use the generic domain validation code that get this right - but that's for later let's push this simple compile fix for now. And sorry for the late fix for this, I have been busy with OLS and associated activities last week. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| * [SCSI] esp: Fix build.David S. Miller2006-07-241-8/+4
| | | | | | | | | | | | | | | | The data_cmd[] member got deleted, so do not use it any more. Scsi commands do not have their ->cmd[] overwritten temporary to probe for status after an error before retrying. Signed-off-by: David S. Miller <davem@davemloft.net>
* | Merge branch 'master' into upstream-fixesJeff Garzik2006-07-2442-500/+573
|\ \ | |/
| * Merge master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6Linus Torvalds2006-07-2142-500/+573
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6: (38 commits) [SCSI] More buffer->request_buffer changes [SCSI] mptfusion: bump version to 3.04.01 [SCSI] mptfusion: misc fix's [SCSI] mptfusion: firmware download boot fix's [SCSI] mptfusion: task abort fix's [SCSI] mptfusion: sas nexus loss support [SCSI] mptfusion: sas loginfo update [SCSI] mptfusion: mptctl panic when loading [SCSI] mptfusion: sas enclosures with smart drive [SCSI] NCR_D700: misc fixes (section and argument ordering) [SCSI] scsi_debug: must_check fixes [SCSI] scsi_transport_sas: kill the use of channel [SCSI] scsi_transport_sas: add expander backlink [SCSI] hide EH backup data outside the scsi_cmnd [SCSI] ibmvscsi: handle inactive SCSI target during probe [SCSI] ibmvscsi: allocate lpevents for ibmvscsi on iseries [SCSI] aic7[9x]xx: Remove last vestiges of reverse_scan [SCSI] aha152x: stop poking at saved scsi_cmnd members [SCSI] st.c: Improve sense output [SCSI] lpfc 8.1.7: Change version number to 8.1.7 ...
| | * [SCSI] More buffer->request_buffer changesChristoph Hellwig2006-07-1413-19/+17
| | | | | | | | | | | | | | | | | | | | | | | | Seem like quite a few splipped through the cracks. Here's a patch to update all references I could find: Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] NCR_D700: misc fixes (section and argument ordering)James Bottomley2006-07-121-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | Apparently the D700 has had an argument ordering issue for quite a while which can cause it to get the wrong scsi_id (I just got an unbootable voyager system because of this). Hopefully this patch also fixes up all the sectional mismatches within the driver. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] scsi_debug: must_check fixesRandy Dunlap2006-07-121-18/+54
| | | | | | | | | | | | | | | | | | | | | | | | Check all __must_check warnings in scsi_debug. Signed-off-by: Randy Dunlap <rdunlap@xenotime.net> Signed-off-by: Douglas Gilbert <dougg@torque.net> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] scsi_transport_sas: kill the use of channel James Bottomley2006-07-121-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | Using the port_id for the channel is completely unnecessary since the host_id/target_id are constructed to be globally unique. Also move the mptsas driver on to virtual channel 1 for its raid devices. Acked-by: "Moore, Eric" <Eric.Moore@lsil.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] scsi_transport_sas: add expander backlinkJames Bottomley2006-07-121-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | This patch adds the ability to add a backlink to a particular port. The idea is to represent properly ports on expanders that are used specifically for linking to the parent device in the topology. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] hide EH backup data outside the scsi_cmndChristoph Hellwig2006-07-097-224/+108
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently struct scsi_cmnd has various fields that are used to backup original data after the corresponding fields have been overridden for EH commands. This means drivers can easily get at it and misuse it. Due to the old_ naming this doesn't happen for most of them, but two that have different names have been used wrong a lot (see previous patch). Another downside is that they unessecarily bloat the scsi_cmnd size. This patch moves them onstack in scsi_send_eh_cmnd to fix those two issues aswell as allowing future EH fixes like moving the EH command submissions to use SG lists like everything else. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] ibmvscsi: handle inactive SCSI target during probeDave C Boutcher2006-07-091-0/+1
| | | | | | | | | | | | | | | | | | | | | Without this patch we register an interrupt with request_irq, but then return a bad return code from the module probe. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] ibmvscsi: allocate lpevents for ibmvscsi on iseriesDave C Boutcher2006-07-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Allocate the correct number of lp events when running ibmvscsi on legacy iseries Signed-off-by: Dave Boutcher <sleddog@us.ibm.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] aic7[9x]xx: Remove last vestiges of reverse_scanMatthew Wilcox2006-07-092-22/+0
| | | | | | | | | | | | | | | | | | | | | Remove last vestiges of the reverse_scan paramater from aic7xxx and aic79xx. Signed-off-by: Matthew Wilcox <matthew@wil.cx> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] aha152x: stop poking at saved scsi_cmnd membersChristoph Hellwig2006-07-091-6/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | Stop poking into the old_ & co scsi_cmnd fields that should only be used in the EH code. Untested, but this is required to move ahead with the EH fixes. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] st.c: Improve sense outputLuben Tuikov2006-07-091-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Convert this: st0: Error with sense data: <6>st: Current: sense key: Illegal Request Additional sense: Invalid field in cdb To this: st0: Current: sense key: Illegal Request Additional sense: Invalid field in cdb Signed-off-by: Luben Tuikov <ltuikov@yahoo.com> Acked-by: Kai Makisara <kai.makisara@kolumbus.fi> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] lpfc 8.1.7: Change version number to 8.1.7James Smart2006-07-091-1/+1
| | | | | | | | | | | | | | | | | | | | | Change version number to 8.1.7 Signed-off-by: James Smart <James.Smart@emulex.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] lpfc 8.1.7: Misc FixesJames Smart2006-07-093-13/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Misc Fixes: - Fix some sparse warnings - casts of address space - Fix handling of the adapter registration string. Each invocation was byteswapping, so every other adapter init attempt failed. - Correct comments and default value for the lpfc_max_luns parameter Signed-off-by: James Smart <James.Smart@emulex.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] lpfc 8.1.7: Add lpfc_sli_flush_mbox_queue() functionJames Smart2006-07-093-1/+21
| | | | | | | | | | | | | | | | | | | | | | | | Add lpfc_sli_flush_mbox_queue() function and use it in lpfc_offline() call to avoid deadlock on thread block. Signed-off-by: James Smart <James.Smart@emulex.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] lpfc 8.1.7: Correct the wait in attachment that delays for topology ↵James Smart2006-07-091-10/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | discovery Correct the wait in attachment that delays for topology discovery Signed-off-by: James Smart <James.Smart@emulex.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] lpfc 8.1.7: Remove depricated sysfs attribute board_onlineJames Smart2006-07-091-42/+0
| | | | | | | | | | | | | | | | | | | | | | | | Remove depricated sysfs attribute board_online, as it's replaced by the new issue_reset attribute Signed-off-by: James Smart <James.Smart@emulex.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] lpfc 8.1.7: Adding new issue_reset sysfs attributeJames Smart2006-07-091-0/+43
| | | | | | | | | | | | | | | | | | | | | Adding new issue_reset sysfs attribute Signed-off-by: James Smart <James.Smart@emulex.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] lpfc 8.1.7: Fix panic in lpfc_sli_validate_fcp_iocbJames Smart2006-07-091-10/+12
| | | | | | | | | | | | | | | | | | | | | | | | Fix panic in lpfc_sli_validate_fcp_iocb due to access of scsi_cmnd after returning it to the midlayer Signed-off-by: James Smart <James.Smart@emulex.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] lpfc 8.1.7: Consolidate dma buf cleanup into a separate functionJames Smart2006-07-091-16/+24
| | | | | | | | | | | | | | | | | | | | | Consolidate dma buf cleanup into a separate function Signed-off-by: James Smart <James.Smart@emulex.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] lpfc 8.1.7: Correct bogus nodev_tmo message on NPort that changes its ↵James Smart2006-07-091-24/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | NPort Id Correct bogus nodev_tmo message on NPort that changes its NPort Id Signed-off-by: James Smart <James.Smart@emulex.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] lpfc 8.1.7: Fix txcmplq related panics on heavy IO while downloading ↵James Smart2006-07-091-7/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | firmware Fix txcmplq related panics on heavy IO while downloading firmware Signed-off-by: James Smart <James.Smart@emulex.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] lpfc 8.1.7: Issue DOWN_LINK prior to INIT_LINK to work around link ↵James Smart2006-07-091-1/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | failure issue Issue DOWN_LINK prior to INIT_LINK to work around link failure issue Signed-off-by: James Smart <James.Smart@emulex.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] lpfc 8.1.7: Fixed infinite retry of REG_LOGIN mailbox failed due to ↵James Smart2006-07-091-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | MBXERR_RPI_FULL Fixed infinite retry of REG_LOGIN mailbox failed due to MBXERR_RPI_FULL Signed-off-by: James Smart <James.Smart@emulex.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] lpfc 8.1.7: Fix memory leak and cleanup code related to per ring ↵James Smart2006-07-093-27/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | lookup array Fix memory leak and cleanup code related to per ring lookup array. Signed-off-by: James Smart <James.Smart@emulex.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] lpfc 8.1.7: Standardize the driver on a single define for the maximum ↵James Smart2006-07-093-7/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | supported targets Standardize the driver on a single define for the maximum supported targets. Signed-off-by: James Smart <James.Smart@emulex.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] lpfc 8.1.7: Use mod_timer instead of add_timer in ↵James Smart2006-07-091-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | lpfc_els_timeout_handler Use mod_timer instead of add_timer in lpfc_els_timeout_handler This patch was formerly posted by Mark Haverkamp. http://marc.theaimsgroup.com/?l=linux-scsi&m=114246089015681&w=2 Signed-off-by: Mark Haverkamp <markh@osdl.org> Signed-off-by: James Smart <James.Smart@emulex.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] update additional sense codes and some opcode namesDouglas Gilbert2006-07-091-38/+88
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Following on from my post titled: "additional sense codes need update" see the attachment against lk 2.6.17 . ChangeLog: - update additional sense codes table to agree with SPC-4 revision 5a (14 June 2006) - adjust some of the opcode names Signed-off-by: Douglas Gilbert <dougg@torque.net> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] scsi_transport_sas: add unindexed portsJames Bottomley2006-07-091-1/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some SAS HBAs don't want to go to the trouble of tracking port numbers, so they'd simply like to say "add this port and give it a number". This is especially beneficial from the hotplug point of view, since tracking ports and the available number space can be a real pain. The current implementation uses an incrementing number per expander to add the port on. However, since there can never be more ports than there are phys, a later implementation will try to be more intelligent about this. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| | * [SCSI] aic79xx: make ahd_done_with_status() staticAdrian Bunk2006-07-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | This patch makes a needlessly global function static. Signed-off-by: Adrian Bunk <bunk@stusta.de> Acked-by: Hannes Reinecke <hare@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
* | | [libata] sata_promise: comment out duplicate PCI IDJeff Garzik2006-07-241-0/+7
| | | | | | | | | | | | | | | This is just the for-RC fix. A 'TODO' command is added, describing what's needed for the more-complete fix.
* | | [PATCH] libata: improve EH action and EHI flag handlingTejun Heo2006-07-191-5/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update ata_eh_about_to_do() and ata_eh_done() to improve EH action and EHI flag handling. * There are two types of EHI flags - one which expires on successful EH and the other which expires on a successful reset. Make this distinction clear. * Unlike other EH actions, reset actions are represented by two EH action masks and a EHI modifier. Implement correct about_to_do/done semantics for resets. That is, prior to reset, related EH info is sucked in from ehi and cleared, and after reset is complete, related EH info in ehc is cleared. These changes improve consistency and remove unnecessary EH actions caused by stale EH action masks and EHI flags. Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>
* | | [PATCH] libata: fix eh_skip_recovery conditionTejun Heo2006-07-191-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * (ata_dev_absent() || ata_dev_ready()) test doesn't indicate SUSPENDED state properly. Fix it. * Link resuming resets shouldn't be skipped. Don't skip recovery on EHI_RESUME_LINK. This doesn't matter for host ports as EHI_RESUME always coincides with EHI_HOTPLUGGED which makes attached disabled devices vacant. However, PMP reset causes non-hotplug link-resuming resets which shouldn't be skipped. Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>
* | | [PATCH] libata: fix autopsy ehc->i.action and ehc->i.dev handlingTejun Heo2006-07-191-17/+12
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit 0662c58b3265f52f708a6d59476bc7862b01f9c0 updated ata_eh_autopsy() to OR determined action to ehc->i.action to preserve action mask set directly into ehc->i.action by nested functions. This broke action mask clearing on SENSE_VALID case causing revalidation and EH complete message on successful ATAPI CC. This patch removes two local variables - action and failed_dev - which cache ehc->i.action and ehc->i.dev respectively, and make the function directly modify ehc->i.* fields to remove aliasing issues. Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>
* | [libata] ata_piix: correct 'invalid MAP value' typo-caused errorJeff Garzik2006-07-161-1/+1
| | | | | | | | Signed-off-by: Jeff Garzik <jeff@garzik.org>
* | [libata] ata_piix: minor cleanups noticed in prior patch runJeff Garzik2006-07-161-11/+7
| | | | | | | | | | | | | | * delete unused PIIX_FLAG_COMBINED* * port_enable should be u16 rather than u32 Signed-off-by: Jeff Garzik <jeff@garzik.org>
OpenPOWER on IntegriCloud