summaryrefslogtreecommitdiffstats
path: root/drivers/scsi/sata_mv.c
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'mv-merge'Jeff Garzik2006-03-291-18/+24
|\ | | | | | | | | | | Conflicts: drivers/scsi/sata_mv.c
| * [PATCH] sata_mv: three bug fixesMark Lord2006-03-291-18/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (1) A DMA transfer size of 0x10000 was not being written as 0x0000 in the PRDs. Fixed. (1) The DEV_IRQ interrupt cause bit happens spuriously during EDMA operation, and was not being ignored by the driver. This led to various "drive busy" errors being reported, with associated unpredictable behaviour. Fixed. (2) If a SATA or PCI interrupt was received with no outstanding command, the interrupt handler still attempted to invoke ata_qc_complete(), triggering assert()/BUG_ON() behaviour elsewhere in libata. Fixed. The driver still has issues with confusion after error-recovery, but should now be reliable in the absence of drive errors. I will be looking more into the error-handling bugs next. Signed-Off-By: Mark Lord <mlord@pobox.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>
* | Merge branch 'master'Jeff Garzik2006-03-221-1/+0
|\ \
| * | [SCSI] libata: implement minimal transport template for ->eh_timed_outTejun Heo2006-03-211-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SCSI midlayer has moved hostt->eh_timed_out to transport template. As libata doesn't need full-blown transport support yet, implement minimal transport for libata. No transport class or whatsoever, just empty transport template with ->eh_timed_out hook. Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
* | | [libata] sata_mv: off-by-1 fixMark Lord2006-03-211-1/+4
|/ / | | | | | | | | | | | | | | | | | | | | | | This patch addresses a number of weird behaviours observed for the sata_mv driver, by fixing an "off by one" bug in processing of the EDMA response queue. Basically, sata_mv was looking in the wrong place for command results, and this produced a lot of unpredictable behaviour. Signed-off-by: Mark Lord <mlord@pobox.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>
* | [libata] sata_mv: fix irq port status usageJeff Garzik2006-03-201-1/+1
| | | | | | | | | | | | | | | | | | Interrupt handler did not properly initialize a variable on a per-port basis, leading to incorrect behavior on ports other than port 0. Bug caught and fixed by Mark Lord. Signed-off-by: Jeff Garzik <jeff@garzik.org>
* | Merge branch 'master'Jeff Garzik2006-02-201-0/+1
|\ \ | |/
| * [PATCH] Add missing FUA write to sata_mv dma command listJens Axboe2006-02-171-0/+1
| | | | | | | | | | Signed-off-by: Jens Axboe <axboe@suse.de> Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
* | [PATCH] libata: kill sht->max_sectorsTejun Heo2006-02-121-1/+0
| | | | | | | | | | | | | | | | The previous dev->max_sectors patch made sht->max_sectors meaningless. Kill all initializations of sht->max_sectors. Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
* | [PATCH] libata: convert assert(xxx)'s in low-level drivers to WARN_ON(!xxx)'sTejun Heo2006-02-111-25/+25
| | | | | | | | | | | | | | | | | | This patch converts all assert(xxx)'s in low-level drivers to WARN_ON(!xxx)'s. After this patch, there is no in-kernel user of the libata assert() macro. Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
* | [PATCH] libata: kill NULL qc handling from ->eng_timeout callbacksTejun Heo2006-02-101-7/+2
| | | | | | | | | | | | | | | | | | ->eng_timeout cannot be invoked with NULL qc anymore. Add an assertion in ata_scsi_error() and kill NULL qc handling from all ->eng_timeout callbacks. Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
* | [PATCH] libata: use ata_scsi_timed_out()Tejun Heo2006-02-101-0/+1
| | | | | | | | | | | | | | Make all libata low level drivers use ata_scsi_timed_out(). Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
* | Merge branch 'upstream-fixes'Jeff Garzik2006-02-021-1/+10
|\ \ | |/
| * [libata sata_mv] do not enable PCI MSI by defaultJeff Garzik2006-02-021-1/+10
| | | | | | | | | | | | | | | | | | | | Several bug reports have come in, noting that disabling CONFIG_PCI_MSI has fixed their problems with this driver. This may be generic system issues, but there is also the probability of unimplemented hardware errata workarounds. Until this ream of bug reports is sorted out, we can get them going in non-MSI interrupt mode. As such, this change adds an 'msi' module option, which defaults to off.
* | [libata sata_mv] add 6042 support, fix 60xx/50xx EDMA configurationJeff Garzik2006-01-311-12/+200
| |
* | [PATCH] libata: implement and apply ata_eh_qc_complete/retry()Tejun Heo2006-01-261-11/+1
| | | | | | | | | | | | | | | | | | | | | | Implement ata_eh_qc_complete/retry() using scsi_eh_finish_cmd() and scsi_eh_flush_done_q(). This removes all eh scsicmd finish hacks from low level drivers. This change was first suggested by Jeff Garzik. Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
* | [PATCH] libata: return AC_ERR_* from issue functionsTejun Heo2006-01-261-2/+2
| | | | | | | | | | | | | | | | | | Return AC_ERR_* mask from issue fuctions instead of 0/-1. This enables things like failing a qc with AC_ERR_HSM when the device doesn't set DRDY when the qc is about to be issued. Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
* | [PATCH] libata: add detailed AC_ERR_* flagsTejun Heo2006-01-261-1/+1
|/ | | | | | | | | | | Add detailed AC_ERR_* flags and use them. Long-term goal is to describe all errors with err_mask and tf combination (tf for failed sector information, etc...). After proper error diagnosis is implemented, sense data should also be generated from err_mask instead of directly from hardware tf registers as it is currently. Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
* [BLOCK] update libata to use new blk_ordered for barriersTejun Heo2006-01-061-1/+0
| | | | | | | | Reflect changes in SCSI midlayer and updated to use new ordered request implementation Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: Jens Axboe <axboe@suse.de>
* Merge branch 'upstream-fixes'Jeff Garzik2005-12-131-1/+2
|\
| * [libata] mark certain hardware (or drivers) with a no-atapi flagJeff Garzik2005-12-131-1/+2
| | | | | | | | | | | | | | | | | | | | Some hardware does not support the PACKET command at all. Other hardware supports ATAPI, but the driver does something nasty such as calling BUG() when an ATAPI command is issued. For these such cases, we mark them with a new flag, ATA_FLAG_NO_ATAPI. Initial version contributed by Ben Collins.
* | [PATCH] libata: move err_mask to ata_queued_cmdAlbert Lee2005-12-061-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | - remove err_mask from the parameter list of the complete functions - move err_mask to ata_queued_cmd - initialize qc->err_mask when needed - for each function call to ata_qc_complete(), replace the err_mask parameter with qc->err_mask. Signed-off-by: Albert Lee <albertcc@tw.ibm.com> =============== Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
* | [PATCH] mark several libata datastructures constArjan van de Ven2005-12-011-1/+1
|/ | | | | | | | | | | Hi, the patch below marks several libata (and libata-driver) structures const so that they end up in the .rodata segment and don't false-share cachelines with things that get dirtied often. Signed-off-by: Arjan van de Ven <arjan@infradead.org> Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
* [libata sata_mv] update copyright, driver versionJeff Garzik2005-11-181-1/+2
|
* [libata sata_mv] handle lack of hardware nIEN supportJeff Garzik2005-11-171-1/+6
| | | | | | | | | | | Handle errata (it was unintentional on this h/w, whereas its intentional on others) whereby the nIEN bit in Device Control is ignored, leading to a situation where a hardware interrupt completes the qc before the polling code has a chance to. This will get fixed The Right Way(tm) once Albert Lee's irq-pio branch is merged, as the more natural PIO method on this hardware is interrupt-driven.
* [libata sata_mv] SATA probe, DMA boundary fixesJeff Garzik2005-11-171-18/+70
| | | | | | | | - DMA boundary was being handled incorrectly. Copied the code from ata_fill_sg(), since Marvell has the same DMA boundary needs. (we can't use ata_fill_sg directly since we have different hardware descriptors) - cleaned up the SATA phy reset code, to deal with various errata
* [libata sata_mv] fix tons of 50XX bugsJeff Garzik2005-11-131-49/+252
|
* [libata sata_mv] call phy fixups during init, as well as phy resetJeff Garzik2005-11-121-12/+26
|
* [libata sata_mv] move code aroundJeff Garzik2005-11-121-100/+100
| | | | No content changes. Move 60xx code to be closer to other 60xx code.
* [libata sata_mv] hardware initialization workJeff Garzik2005-11-121-12/+105
| | | | | Implement flash reset and PCI reset on 50xx and 60xx. Implement LED enable on 50xx.
* [libata sata_mv] mv_hw_ops for hardware families; new errataJeff Garzik2005-11-121-138/+158
| | | | | | - eliminate a bunch of redundant tests by creating a per-chip-family set of hooks, mv_hw_ops - implement more errata, from newer Marvell GPL'd driver
* [libata sata_mv] move code aroundJeff Garzik2005-11-121-48/+48
| | | | No content change, just prepping up future mv_hw_ops modularization.
* [libata sata_mv] implement a bunch of errata workaroundsJeff Garzik2005-11-121-7/+261
| | | | Based largely on the GPL'd Marvell vendor driver.
* [libata sata_mv] trim trailing whitespaceJeff Garzik2005-11-121-38/+38
|
* [libata sata_mv] minor fixesJeff Garzik2005-11-121-10/+22
| | | | | - clear SError and EDMA irq cause registers, after re-init'ing the phy - move enums with type suffix 'U' to their own enum
* [libata sata_mv] add Adaptec 1420SA PCI IDJeff Garzik2005-11-111-0/+2
| | | | Contributed by Jeroen <dekien@pandora.be>
* [libata] constify PCI ID table in several driversJeff Garzik2005-11-101-1/+1
|
* [libata] eliminate use of drivers/scsi/scsi.h compatibility header/definesJeff Garzik2005-11-071-2/+2
|
* [libata] ATAPI pad allocation fixes/cleanupJeff Garzik2005-11-041-8/+23
| | | | | | | Use ata_pad_{alloc,free} in two drivers, to factor out common code. Add ata_pad_{alloc,free} to two other drivers, which needed the padding but had not been updated.
* Merge branch 'master'Jeff Garzik2005-10-301-6/+6
|\
| * [libata] use dev_printk() throughout driversJeff Garzik2005-10-301-6/+6
| | | | | | | | | | | | A few drivers were not following the standard meme of printing out their driver name and version at module load time; this is fixed as well.
* | Merge branch 'upstream'Jeff Garzik2005-10-301-5/+6
|\ \ | |/
| * [libata] change ata_qc_complete() to take error mask as second argJeff Garzik2005-10-301-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The second argument to ata_qc_complete() was being used for two purposes: communicate the ATA Status register to the completion function, and indicate an error. On legacy PCI IDE hardware, the latter is often implicit in the former. On more modern hardware, the driver often completely emulated a Status register value, passing ATA_ERR as an indication that something went wrong. Now that previous code changes have eliminated the need to use drv_stat arg to communicate the ATA Status register value, we can convert it to a mask of possible error classes. This will lead to more flexible error handling in the future.
* | Merge branch 'upstream'Jeff Garzik2005-10-301-18/+0
|\ \ | |/
| * [libata] remove ata_chk_err(), ->check_err() hook.Jeff Garzik2005-10-291-18/+0
| | | | | | | | | | We now depend on ->tf_read() to provide us with the contents of the Error shadow register.
* | Merge branch 'master'Jeff Garzik2005-10-281-2/+2
|\ \ | |/
| * libata: const-ification bombing runJeff Garzik2005-10-221-1/+1
| | | | | | | | | | | | | | Enforce access rules where appropriate. If the compiler is smart enough, this may buy us an optimization or two as a side effect.
| * [PATCH] libata: Marvell endian fixBrett Russ2005-10-201-2/+3
| | | | | | | | | | | | | | | | Jeff found an endian bug in the Marvell driver (thanks!). Here's the fix for it. Signed-off-by: Brett Russ <russb@emc.com> Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
* | libata: add ata_sg_is_last() helper, use it in several driversJeff Garzik2005-10-181-7/+9
|/
* [libata sata_mv] fix warningJeff Garzik2005-10-051-2/+3
| | | | | shuffle ifdef location to fix the following warning: drivers/scsi/sata_mv.c:471: warning: 'mv_dump_mem' defined but not used
OpenPOWER on IntegriCloud