diff options
| author | Adrian Hunter <adrian.hunter@intel.com> | 2013-12-03 09:23:08 +0200 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2013-12-04 13:46:36 -0300 |
| commit | 0058aef65eda9c9dde8253af702d542ba7eef697 (patch) | |
| tree | bd140e8170b3404d6963464b0e1a0ec820fa7cfe /tools/perf | |
| parent | 454ff00f969e515c4cbfd52718ec5e01c7d9aeef (diff) | |
| download | blackbird-op-linux-0058aef65eda9c9dde8253af702d542ba7eef697.tar.gz blackbird-op-linux-0058aef65eda9c9dde8253af702d542ba7eef697.zip | |
perf symbols: Retain symbol source file name to lookup source line numbers
Currently, lookup of an ip's source file name and line number is done
using the dso file name.
Instead retain the file name used to lookup the dso's symbols and use
that.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1386055390-13757-6-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf')
| -rw-r--r-- | tools/perf/util/dso.c | 1 | ||||
| -rw-r--r-- | tools/perf/util/dso.h | 1 | ||||
| -rw-r--r-- | tools/perf/util/srcline.c | 7 | ||||
| -rw-r--r-- | tools/perf/util/symbol.c | 2 |
4 files changed, 10 insertions, 1 deletions
diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c index 68aa55aa5c17..49da9684f635 100644 --- a/tools/perf/util/dso.c +++ b/tools/perf/util/dso.c @@ -470,6 +470,7 @@ void dso__delete(struct dso *dso) free(dso->long_name); dso_cache__free(&dso->cache); dso__free_a2l(dso); + free(dso->symsrc_filename); free(dso); } diff --git a/tools/perf/util/dso.h b/tools/perf/util/dso.h index d8613dc3ca8f..7142e5261266 100644 --- a/tools/perf/util/dso.h +++ b/tools/perf/util/dso.h @@ -78,6 +78,7 @@ struct dso { struct rb_root symbol_names[MAP__NR_TYPES]; struct rb_root cache; void *a2l; + char *symsrc_filename; enum dso_kernel_type kernel; enum dso_swap_type needs_swap; enum dso_binary_type symtab_type; diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c index 25b85b28301b..93795f9c2480 100644 --- a/tools/perf/util/srcline.c +++ b/tools/perf/util/srcline.c @@ -249,11 +249,16 @@ char *get_srcline(struct dso *dso, unsigned long addr) char *file = NULL; unsigned line = 0; char *srcline; - char *dso_name = dso->long_name; + char *dso_name; if (!dso->has_srcline) return SRCLINE_UNKNOWN; + if (dso->symsrc_filename) + dso_name = dso->symsrc_filename; + else + dso_name = dso->long_name; + if (dso_name[0] == '[') goto out; diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index 360eefecb81d..de87dbac50a0 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c @@ -1336,6 +1336,8 @@ int dso__load(struct dso *dso, struct map *map, symbol_filter_t filter) if (!syms_ss && symsrc__has_symtab(ss)) { syms_ss = ss; next_slot = true; + if (!dso->symsrc_filename) + dso->symsrc_filename = strdup(name); } if (!runtime_ss && symsrc__possibly_runtime(ss)) { |
