diff options
| author | Cody P Schafer <cody@linux.vnet.ibm.com> | 2012-08-10 15:23:00 -0700 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2012-08-13 14:37:37 -0300 |
| commit | d26cd12b46cb6b5595143804b43ba5aa7968551e (patch) | |
| tree | 80a2c383f5b3d06d17692d65abd734102e37b8b3 /tools/perf/util/symbol-minimal.c | |
| parent | a44f605b2f6eadb771a052aa3a5eefb342b38a39 (diff) | |
| download | blackbird-op-linux-d26cd12b46cb6b5595143804b43ba5aa7968551e.tar.gz blackbird-op-linux-d26cd12b46cb6b5595143804b43ba5aa7968551e.zip | |
perf symbols: Factor want_symtab out of dso__load_sym()
Only one callsite of dso__load_sym() uses the want_symtab functionality,
so place the logic at the callsite instead of within dso__load_sym().
This sets us up for removal of want_symtab completely once we keep
multiple elf handles (within symsrc's) around.
Setup for the later patch
"perf symbols: Use both runtime and debug images"
Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
Cc: David Hansen <dave@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Matt Hellsley <matthltc@us.ibm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/1344637382-22789-15-git-send-email-cody@linux.vnet.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/symbol-minimal.c')
| -rw-r--r-- | tools/perf/util/symbol-minimal.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/tools/perf/util/symbol-minimal.c b/tools/perf/util/symbol-minimal.c index cc580c046c04..11c2c606ce77 100644 --- a/tools/perf/util/symbol-minimal.c +++ b/tools/perf/util/symbol-minimal.c @@ -260,6 +260,11 @@ out_close: return -1; } +bool symsrc__has_symtab(struct symsrc *ss __used) +{ + return false; +} + void symsrc__destroy(struct symsrc *ss) { free(ss->name); @@ -275,8 +280,7 @@ int dso__synthesize_plt_symbols(struct dso *dso __used, } int dso__load_sym(struct dso *dso, struct map *map __used, struct symsrc *ss, - symbol_filter_t filter __used, int kmodule __used, - int want_symtab __used) + symbol_filter_t filter __used, int kmodule __used) { unsigned char *build_id[BUILD_ID_SIZE]; |
