diff options
| author | Eric Dumazet <edumazet@google.com> | 2017-05-05 06:56:54 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-05-14 14:06:02 +0200 |
| commit | f8e3892f9f237b96dcba5560d2050bffcbfdbb32 (patch) | |
| tree | 380fa3df04004929a63252a2a6640a98c9a5bdcf /tools/perf/util/scripting-engines/trace-event-perl.c | |
| parent | 3960afa2e02f86463e893d0d5583b1e612f6f1ea (diff) | |
| download | blackbird-op-linux-f8e3892f9f237b96dcba5560d2050bffcbfdbb32.tar.gz blackbird-op-linux-f8e3892f9f237b96dcba5560d2050bffcbfdbb32.zip | |
tcp: randomize timestamps on syncookies
[ Upstream commit 84b114b98452c431299d99c135f751659e517acb ]
Whole point of randomization was to hide server uptime, but an attacker
can simply start a syn flood and TCP generates 'old style' timestamps,
directly revealing server jiffies value.
Also, TSval sent by the server to a particular remote address vary
depending on syncookies being sent or not, potentially triggering PAWS
drops for innocent clients.
Lets implement proper randomization, including for SYNcookies.
Also we do not need to export sysctl_tcp_timestamps, since it is not
used from a module.
In v2, I added Florian feedback and contribution, adding tsoff to
tcp_get_cookie_sock().
v3 removed one unused variable in tcp_v4_connect() as Florian spotted.
Fixes: 95a22caee396c ("tcp: randomize tcp timestamp offsets for each connection")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Florian Westphal <fw@strlen.de>
Tested-by: Florian Westphal <fw@strlen.de>
Cc: Yuchung Cheng <ycheng@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'tools/perf/util/scripting-engines/trace-event-perl.c')
0 files changed, 0 insertions, 0 deletions
