diff options
| author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2009-10-26 19:23:17 -0200 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2009-10-27 13:51:53 +0100 |
| commit | 7f3bedcc93f935631d2363f23de1cc80f04fdf3e (patch) | |
| tree | 3fb5bc27a52e6d41395c7361c46f91d4d909a6c8 /tools/perf/builtin-record.c | |
| parent | fcd14b3203b538dca04a2b065c774c0b57863eec (diff) | |
| download | blackbird-op-linux-7f3bedcc93f935631d2363f23de1cc80f04fdf3e.tar.gz blackbird-op-linux-7f3bedcc93f935631d2363f23de1cc80f04fdf3e.zip | |
perf record: Fix race where process can disappear while reading its /proc/pid/tasks
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Mike Galbraith <efault@gmx.de>
LKML-Reference: <1256592199-9608-1-git-send-email-acme@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'tools/perf/builtin-record.c')
| -rw-r--r-- | tools/perf/builtin-record.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index ac5ddfff4456..9e1638cc19c8 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -206,6 +206,7 @@ static pid_t pid_synthesize_comm_event(pid_t pid, int full) fp = fopen(filename, "r"); if (fp == NULL) { +out_race: /* * We raced with a task exiting - just return: */ @@ -247,6 +248,9 @@ static pid_t pid_synthesize_comm_event(pid_t pid, int full) snprintf(filename, sizeof(filename), "/proc/%d/task", pid); tasks = opendir(filename); + if (tasks == NULL) + goto out_race; + while (!readdir_r(tasks, &dirent, &next) && next) { char *end; pid = strtol(dirent.d_name, &end, 10); |
