diff options
author | Takashi Iwai <tiwai@suse.de> | 2012-11-13 11:22:48 +0100 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2012-11-14 15:29:09 +0100 |
commit | 10e44239f67d0b6fb74006e61a7e883b8075247a (patch) | |
tree | bddffd5e211ccab10512858dce5b4a6cde74db59 /sound/usb/midi.c | |
parent | effded75e24c7941961d473e4f4babed4c52af3c (diff) | |
download | blackbird-op-linux-10e44239f67d0b6fb74006e61a7e883b8075247a.tar.gz blackbird-op-linux-10e44239f67d0b6fb74006e61a7e883b8075247a.zip |
ALSA: usb-audio: Fix mutex deadlock at disconnection
The recent change for USB-audio disconnection race fixes introduced a
mutex deadlock again. There is a circular dependency between
chip->shutdown_rwsem and pcm->open_mutex, depicted like below, when a
device is opened during the disconnection operation:
A. snd_usb_audio_disconnect() ->
card.c::register_mutex ->
chip->shutdown_rwsem (write) ->
snd_card_disconnect() ->
pcm.c::register_mutex ->
pcm->open_mutex
B. snd_pcm_open() ->
pcm->open_mutex ->
snd_usb_pcm_open() ->
chip->shutdown_rwsem (read)
Since the chip->shutdown_rwsem protection in the case A is required
only for turning on the chip->shutdown flag and it doesn't have to be
taken for the whole operation, we can reduce its window in
snd_usb_audio_disconnect().
Reported-by: Jiri Slaby <jslaby@suse.cz>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/usb/midi.c')
0 files changed, 0 insertions, 0 deletions