summaryrefslogtreecommitdiffstats
path: root/sound/isa
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2014-11-21 19:05:50 +0100
committerTakashi Iwai <tiwai@suse.de>2014-11-21 20:07:13 +0100
commit42d772101274492ca15258ea346e6ebbc2bc9bd0 (patch)
tree9cd4f78fd63af1796c99c58ea97b2563a5e4f3e5 /sound/isa
parentd712eaf29d3fe5928d891a4a90ac58644ad595ed (diff)
downloadblackbird-op-linux-42d772101274492ca15258ea346e6ebbc2bc9bd0.tar.gz
blackbird-op-linux-42d772101274492ca15258ea346e6ebbc2bc9bd0.zip
ALSA: es1688_lib: Deletion of an unnecessary check before the function call "release_and_free_resource"
The release_and_free_resource() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/isa')
-rw-r--r--sound/isa/es1688/es1688_lib.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/sound/isa/es1688/es1688_lib.c b/sound/isa/es1688/es1688_lib.c
index de810e484bdf..b5450143407b 100644
--- a/sound/isa/es1688/es1688_lib.c
+++ b/sound/isa/es1688/es1688_lib.c
@@ -614,8 +614,7 @@ static int snd_es1688_free(struct snd_es1688 *chip)
{
if (chip->hardware != ES1688_HW_UNDEF)
snd_es1688_init(chip, 0);
- if (chip->res_port)
- release_and_free_resource(chip->res_port);
+ release_and_free_resource(chip->res_port);
if (chip->irq >= 0)
free_irq(chip->irq, (void *) chip);
if (chip->dma8 >= 0) {
OpenPOWER on IntegriCloud