summaryrefslogtreecommitdiffstats
path: root/sound/drivers
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2008-11-27 15:40:40 +0100
committerTakashi Iwai <tiwai@suse.de>2008-11-27 15:42:15 +0100
commit73f6a12ed187b7e7ac9334d1419ba7bf7ac1be26 (patch)
treefd88332a69ce13ca9253e586a6c5d828f747d388 /sound/drivers
parent12666f050b3b4b122f61ef12707f33fadb4a78b5 (diff)
downloadblackbird-op-linux-73f6a12ed187b7e7ac9334d1419ba7bf7ac1be26.tar.gz
blackbird-op-linux-73f6a12ed187b7e7ac9334d1419ba7bf7ac1be26.zip
ALSA: sound/pci/mixart/mixart.c: Add missing snd_card_free
The function snd_mixart_create creates a link between mgr and card that allows snd_mixart_free to free card as well. But if snd_mixart_create fails, then the link has not been created and card has to be freed explicitly. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r exists@ local idexpression x; statement S,S1; position p1,p2,p3; expression E,E1; type T,T1; expression *ptr != NULL; @@ ( if ((x@p1 = snd_card_new(...)) == NULL) S | x@p1 = snd_card_new(...); ) ... when != snd_card_free(...,(T)x,...) when != if (...) { <+... snd_card_free(...,(T)x,...) ...+> } when != true x == NULL || ... when != x = E when != E = (T)x when any ( if (x == NULL || ...) S1 | if@p2 (...) { ... when != snd_card_free(...,(T1)x,...) when != if (...) { <+... snd_card_free(...,(T1)x,...) ...+> } when != x = E1 when != E1 = (T1)x ( return \(0\|<+...x...+>\|ptr\); | return@p3 ...; ) } ) @ script:python @ p1 << r.p1; p3 << r.p3; @@ print "* file: %s snd_card_new: %s return: %s" % (p1[0].file,p1[0].line,p3[0].line) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/drivers')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud