diff options
author | Dave Chinner <dchinner@redhat.com> | 2014-11-07 08:30:58 +1100 |
---|---|---|
committer | Dave Chinner <david@fromorbit.com> | 2014-11-07 08:30:58 +1100 |
commit | 2b831ac6bc87d3cbcbb1a8816827b6923403e461 (patch) | |
tree | e1c5fb18fa99b4a6b025d716e29793df06861119 /security | |
parent | bf4a5af20d25ecc8876978ad34b8db83b4235f3c (diff) | |
download | blackbird-op-linux-2b831ac6bc87d3cbcbb1a8816827b6923403e461.tar.gz blackbird-op-linux-2b831ac6bc87d3cbcbb1a8816827b6923403e461.zip |
xfs: bulkstat chunk-formatter has issues
The loop construct has issues:
- clustidx is completely unused, so remove it.
- the loop tries to be smart by terminating when the
"freecount" tells it that all inodes are free. Just drop
it as in most cases we have to scan all inodes in the
chunk anyway.
- move the "user buffer left" condition check to the only
point where we consume space int eh user buffer.
- move the initialisation of agino out of the loop, leaving
just a simple loop control logic using the clusteridx.
Also, double handling of the user buffer variables leads to problems
tracking the current state - use the cursor variables directly
rather than keeping local copies and then having to update the
cursor before returning.
cc: <stable@vger.kernel.org> # 3.17
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Diffstat (limited to 'security')
0 files changed, 0 insertions, 0 deletions