diff options
author | J. Bruce Fields <bfields@citi.umich.edu> | 2008-01-22 17:40:42 -0500 |
---|---|---|
committer | J. Bruce Fields <bfields@citi.umich.edu> | 2008-02-01 16:42:15 -0500 |
commit | 87d26ea7771ad637035e6bd5a2700d81ee9162da (patch) | |
tree | c1da6cd6fe03bfadb3276bd30423c7d4b105ef41 /security | |
parent | 50431d94e732ba71b66a83c5435890728e313095 (diff) | |
download | blackbird-op-linux-87d26ea7771ad637035e6bd5a2700d81ee9162da.tar.gz blackbird-op-linux-87d26ea7771ad637035e6bd5a2700d81ee9162da.zip |
nfsd: more careful input validation in nfsctl write methods
Neil Brown points out that we're checking buf[size-1] in a couple places
without first checking whether size is zero.
Actually, given the implementation of simple_transaction_get(), buf[-1]
is zero, so in both of these cases the subsequent check of the value of
buf[size-1] will catch this case.
But it seems fragile to depend on that, so add explicit checks for this
case.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Acked-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'security')
0 files changed, 0 insertions, 0 deletions