summaryrefslogtreecommitdiffstats
path: root/samples
diff options
context:
space:
mode:
authorJonathan Nieder <jrnieder@gmail.com>2011-08-08 06:22:43 +0200
committerLinus Torvalds <torvalds@linux-foundation.org>2011-08-09 18:22:22 -0700
commitf2c0d0266cc5eb36a4aa44944b4096ec121490aa (patch)
tree1f3ec14316bf428e278c06059868c85c87df53cb /samples
parent9f50fad65b87a8776ae989ca059ad6c17925dfc3 (diff)
downloadblackbird-op-linux-f2c0d0266cc5eb36a4aa44944b4096ec121490aa.tar.gz
blackbird-op-linux-f2c0d0266cc5eb36a4aa44944b4096ec121490aa.zip
cap_syslog: don't use WARN_ONCE for CAP_SYS_ADMIN deprecation warning
syslog-ng versions before 3.3.0beta1 (2011-05-12) assume that CAP_SYS_ADMIN is sufficient to access syslog, so ever since CAP_SYSLOG was introduced (2010-11-25) they have triggered a warning. Commit ee24aebffb75 ("cap_syslog: accept CAP_SYS_ADMIN for now") improved matters a little by making syslog-ng work again, just keeping the WARN_ONCE(). But still, this is a warning that writes a stack trace we don't care about to syslog, sets a taint flag, and alarms sysadmins when nothing worse has happened than use of an old userspace with a recent kernel. Convert the WARN_ONCE to a printk_once to avoid that while continuing to give userspace developers a hint that this is an unwanted backward-compatibility feature and won't be around forever. Reported-by: Ralf Hildebrandt <ralf.hildebrandt@charite.de> Reported-by: Niels <zorglub_olsen@hotmail.com> Reported-by: Paweł Sikora <pluto@agmk.net> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Liked-by: Gergely Nagy <algernon@madhouse-project.org> Acked-by: Serge Hallyn <serge@hallyn.com> Acked-by: James Morris <jmorris@namei.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'samples')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud