diff options
| author | Patrick McHardy <kaber@trash.net> | 2008-04-17 23:19:55 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-04-17 23:19:55 -0700 |
| commit | f5ba2d32170679eb9b7c251ac3d9687916a41c18 (patch) | |
| tree | d0bd86075cf7437e9022955eb8813c388178f544 /net | |
| parent | 53083773dcbd3c80477e2ace143e361e1e806745 (diff) | |
| download | blackbird-op-linux-f5ba2d32170679eb9b7c251ac3d9687916a41c18.tar.gz blackbird-op-linux-f5ba2d32170679eb9b7c251ac3d9687916a41c18.zip | |
[PKT_SCHED]: Fix datalen check in tcf_simp_init().
datalen is unsigned so it can never be less than zero,
but that's ok because the attribute passed to nla_len()
has been validated and therefore a negative return
value is impossible.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/sched/act_simple.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sched/act_simple.c b/net/sched/act_simple.c index fbde461b716c..64b2d136c78e 100644 --- a/net/sched/act_simple.c +++ b/net/sched/act_simple.c @@ -115,7 +115,7 @@ static int tcf_simp_init(struct nlattr *nla, struct nlattr *est, return -EINVAL; datalen = nla_len(tb[TCA_DEF_DATA]); - if (datalen <= 0) + if (datalen == 0) return -EINVAL; pc = tcf_hash_check(parm->index, a, bind, &simp_hash_info); |
