diff options
| author | Pablo Neira Ayuso <pablo@netfilter.org> | 2009-04-22 02:26:37 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-04-22 02:26:37 -0700 |
| commit | 29fe1b481283a1bada994a69f65736db4ae6f35f (patch) | |
| tree | f82d3dfa2ad1e44776ef2e2b6e794ab22738cdf1 /net | |
| parent | cc29c70dd581f85ee7a3e7980fb031f90b90a2ab (diff) | |
| download | blackbird-op-linux-29fe1b481283a1bada994a69f65736db4ae6f35f.tar.gz blackbird-op-linux-29fe1b481283a1bada994a69f65736db4ae6f35f.zip | |
netfilter: ctnetlink: fix gcc warning during compilation
This patch fixes a (bogus?) gcc warning during compilation:
net/netfilter/nf_conntrack_netlink.c:1234: warning: 'helpname' may be used uninitialized in this function
net/netfilter/nf_conntrack_netlink.c:991: warning: 'helpname' may be used uninitialized in this function
In fact, helpname is initialized by ctnetlink_parse_help() so
I cannot see a way to use it without being initialized.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/netfilter/nf_conntrack_netlink.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c index 0ea36e0c8a0e..f13fc57e1ecb 100644 --- a/net/netfilter/nf_conntrack_netlink.c +++ b/net/netfilter/nf_conntrack_netlink.c @@ -988,7 +988,7 @@ ctnetlink_change_helper(struct nf_conn *ct, struct nlattr *cda[]) { struct nf_conntrack_helper *helper; struct nf_conn_help *help = nfct_help(ct); - char *helpname; + char *helpname = NULL; int err; /* don't change helper of sibling connections */ @@ -1231,7 +1231,7 @@ ctnetlink_create_conntrack(struct nlattr *cda[], rcu_read_lock(); if (cda[CTA_HELP]) { - char *helpname; + char *helpname = NULL; err = ctnetlink_parse_help(cda[CTA_HELP], &helpname); if (err < 0) |
