diff options
author | Fred Isaman <iisaman@netapp.com> | 2011-02-11 15:42:36 +0000 |
---|---|---|
committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2011-03-11 15:38:40 -0500 |
commit | eabf5baaaaf41b6a0273043cfb06d53dca67acef (patch) | |
tree | d3af759bccd76ecb3b1f1b5ec027193051b55734 /net/sunrpc/clnt.c | |
parent | cee6a5372f8804f58acc87f07816f64db36718e2 (diff) | |
download | blackbird-op-linux-eabf5baaaaf41b6a0273043cfb06d53dca67acef.tar.gz blackbird-op-linux-eabf5baaaaf41b6a0273043cfb06d53dca67acef.zip |
RPC: clarify rpc_run_task error handling
rpc_run_task can only fail if it is not passed in a preallocated task.
However, that is not at all clear with the current code. So
remove several impossible to occur failure checks.
Signed-off-by: Fred Isaman <iisaman@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'net/sunrpc/clnt.c')
-rw-r--r-- | net/sunrpc/clnt.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index 57d344cf2256..8b5a6b40d37c 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c @@ -636,12 +636,6 @@ struct rpc_task *rpc_run_task(const struct rpc_task_setup *task_setup_data) rpc_task_set_client(task, task_setup_data->rpc_client); rpc_task_set_rpc_message(task, task_setup_data->rpc_message); - if (task->tk_status != 0) { - int ret = task->tk_status; - rpc_put_task(task); - return ERR_PTR(ret); - } - if (task->tk_action == NULL) rpc_call_start(task); |