diff options
| author | stephen hemminger <shemminger@vyatta.com> | 2010-05-14 14:38:59 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-05-17 17:44:35 -0700 |
| commit | f0cd15081a72075df16c45a2310e873fb9fcd82f (patch) | |
| tree | 88e462778635cb4e285315f144b62276bdcff6df /net/sched | |
| parent | ccbd6a5a4f76e821ed36f69fdaf59817c3a7f18e (diff) | |
| download | blackbird-op-linux-f0cd15081a72075df16c45a2310e873fb9fcd82f.tar.gz blackbird-op-linux-f0cd15081a72075df16c45a2310e873fb9fcd82f.zip | |
tbf: stop wanton destruction of children (v2)
Several netem users use TBF for rate control. But every time the parameters
of TBF are changed it destroys the child qdisc, requiring reconfigation.
Better to just keep child qdisc and just notify it of changed limit.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched')
| -rw-r--r-- | net/sched/sch_tbf.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/net/sched/sch_tbf.c b/net/sched/sch_tbf.c index 8fb8107ab188..0991c640cd3e 100644 --- a/net/sched/sch_tbf.c +++ b/net/sched/sch_tbf.c @@ -273,7 +273,11 @@ static int tbf_change(struct Qdisc* sch, struct nlattr *opt) if (max_size < 0) goto done; - if (qopt->limit > 0) { + if (q->qdisc != &noop_qdisc) { + err = fifo_set_limit(q->qdisc, qopt->limit); + if (err) + goto done; + } else if (qopt->limit > 0) { child = fifo_create_dflt(sch, &bfifo_qdisc_ops, qopt->limit); if (IS_ERR(child)) { err = PTR_ERR(child); |
