diff options
| author | Alexey Dobriyan <adobriyan@gmail.com> | 2005-09-27 15:43:46 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2005-09-27 15:43:46 -0700 |
| commit | 70ff3b66d79c5110e533f3f2aea1a5b2fc5f8d90 (patch) | |
| tree | 49eb955f8989de09ae4a77fcf8b92538f4a76bdb /net/rose/af_rose.c | |
| parent | c3c4ed652e8f2c348ebdd3f2e45664a0e238ee52 (diff) | |
| download | blackbird-op-linux-70ff3b66d79c5110e533f3f2aea1a5b2fc5f8d90.tar.gz blackbird-op-linux-70ff3b66d79c5110e533f3f2aea1a5b2fc5f8d90.zip | |
[ROSE]: return sane -E* from rose_proto_init()
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rose/af_rose.c')
| -rw-r--r-- | net/rose/af_rose.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/net/rose/af_rose.c b/net/rose/af_rose.c index a190eaee702e..dbfb0e3dc798 100644 --- a/net/rose/af_rose.c +++ b/net/rose/af_rose.c @@ -1482,14 +1482,14 @@ static int __init rose_proto_init(void) if (rose_ndevs > 0x7FFFFFFF/sizeof(struct net_device *)) { printk(KERN_ERR "ROSE: rose_proto_init - rose_ndevs parameter to large\n"); proto_unregister(&rose_proto); - return -1; + return -EINVAL; } dev_rose = kmalloc(rose_ndevs * sizeof(struct net_device *), GFP_KERNEL); if (dev_rose == NULL) { printk(KERN_ERR "ROSE: rose_proto_init - unable to allocate device structure\n"); proto_unregister(&rose_proto); - return -1; + return -ENOMEM; } memset(dev_rose, 0x00, rose_ndevs * sizeof(struct net_device*)); @@ -1502,9 +1502,11 @@ static int __init rose_proto_init(void) name, rose_setup); if (!dev) { printk(KERN_ERR "ROSE: rose_proto_init - unable to allocate memory\n"); + rc = -ENOMEM; goto fail; } - if (register_netdev(dev)) { + rc = register_netdev(dev); + if (rc) { printk(KERN_ERR "ROSE: netdevice regeistration failed\n"); free_netdev(dev); goto fail; @@ -1539,7 +1541,7 @@ fail: } kfree(dev_rose); proto_unregister(&rose_proto); - return -ENOMEM; + goto out; } module_init(rose_proto_init); |
