summaryrefslogtreecommitdiffstats
path: root/net/mac80211/sta_info.c
diff options
context:
space:
mode:
authorJouni Malinen <jouni@qca.qualcomm.com>2011-08-11 11:46:22 +0300
committerJohn W. Linville <linville@tuxdriver.com>2011-08-11 14:23:06 -0400
commitf612cedfe152b536197c0120f2e7779bc90219d0 (patch)
treec1ad3b3a00a26eff4b78d81331c168faf901a4ba /net/mac80211/sta_info.c
parent040bdf713d2bec8235f1af705e2d13da5d9baec8 (diff)
downloadblackbird-op-linux-f612cedfe152b536197c0120f2e7779bc90219d0.tar.gz
blackbird-op-linux-f612cedfe152b536197c0120f2e7779bc90219d0.zip
nl80211/cfg80211: Make addition of new sinfo fields safer
Add a comment pointing out the use of enum station_info_flags for all new struct station_info fields. In addition, memset the sinfo buffer to zero before use on all paths in the current tree to avoid leaving uninitialized pointers in the data. Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'net/mac80211/sta_info.c')
-rw-r--r--net/mac80211/sta_info.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
index 3db78b696c5c..5eaa1673a8f5 100644
--- a/net/mac80211/sta_info.c
+++ b/net/mac80211/sta_info.c
@@ -330,6 +330,7 @@ static int sta_info_finish_insert(struct sta_info *sta, bool async)
ieee80211_sta_debugfs_add(sta);
rate_control_add_sta_debugfs(sta);
+ memset(&sinfo, 0, sizeof(sinfo));
sinfo.filled = 0;
sinfo.generation = local->sta_generation;
cfg80211_new_sta(sdata->dev, sta->sta.addr, &sinfo, GFP_KERNEL);
OpenPOWER on IntegriCloud