diff options
| author | Eric Dumazet <eric.dumazet@gmail.com> | 2010-05-31 16:41:35 +0200 |
|---|---|---|
| committer | Patrick McHardy <kaber@trash.net> | 2010-05-31 16:41:35 +0200 |
| commit | 7489aec8eed4f2f1eb3b4d35763bd3ea30b32ef5 (patch) | |
| tree | fe2450679dc217183421e606b3912641545596bd /net/ipv4 | |
| parent | c936e8bd1de2fa50c49e3df6fa5036bf07870b67 (diff) | |
| download | blackbird-op-linux-7489aec8eed4f2f1eb3b4d35763bd3ea30b32ef5.tar.gz blackbird-op-linux-7489aec8eed4f2f1eb3b4d35763bd3ea30b32ef5.zip | |
netfilter: xtables: stackptr should be percpu
commit f3c5c1bfd4 (netfilter: xtables: make ip_tables reentrant)
introduced a performance regression, because stackptr array is shared by
all cpus, adding cache line ping pongs. (16 cpus share a 64 bytes cache
line)
Fix this using alloc_percpu()
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-By: Jan Engelhardt <jengelh@medozas.de>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Diffstat (limited to 'net/ipv4')
| -rw-r--r-- | net/ipv4/netfilter/ip_tables.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/netfilter/ip_tables.c b/net/ipv4/netfilter/ip_tables.c index 63958f3394a5..4b6c5ca610fc 100644 --- a/net/ipv4/netfilter/ip_tables.c +++ b/net/ipv4/netfilter/ip_tables.c @@ -336,7 +336,7 @@ ipt_do_table(struct sk_buff *skb, cpu = smp_processor_id(); table_base = private->entries[cpu]; jumpstack = (struct ipt_entry **)private->jumpstack[cpu]; - stackptr = &private->stackptr[cpu]; + stackptr = per_cpu_ptr(private->stackptr, cpu); origptr = *stackptr; e = get_entry(table_base, private->hook_entry[hook]); |
