diff options
| author | Eric Dumazet <edumazet@google.com> | 2012-08-07 00:47:11 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-08-08 15:57:46 -0700 |
| commit | 0c03eca3d995e73d691edea8c787e25929ec156d (patch) | |
| tree | bf32062d9e69fe0c5d91587e5be3fcaaa0972433 /net/ipv4/fib_trie.c | |
| parent | 08252b32311c3fa84219ad794d640af7399b5485 (diff) | |
| download | blackbird-op-linux-0c03eca3d995e73d691edea8c787e25929ec156d.tar.gz blackbird-op-linux-0c03eca3d995e73d691edea8c787e25929ec156d.zip | |
net: fib: fix incorrect call_rcu_bh()
After IP route cache removal, I believe rcu_bh() has very little use and
we should remove this RCU variant, since it adds some cycles in fast
path.
Anyway, the call_rcu_bh() use in fib_true is obviously wrong, since
some users only assert rcu_read_lock().
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/fib_trie.c')
| -rw-r--r-- | net/ipv4/fib_trie.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c index f0cdb30921c0..57bd978483e1 100644 --- a/net/ipv4/fib_trie.c +++ b/net/ipv4/fib_trie.c @@ -367,7 +367,7 @@ static void __leaf_free_rcu(struct rcu_head *head) static inline void free_leaf(struct leaf *l) { - call_rcu_bh(&l->rcu, __leaf_free_rcu); + call_rcu(&l->rcu, __leaf_free_rcu); } static inline void free_leaf_info(struct leaf_info *leaf) |
