diff options
| author | Robert Olsson <robert.olsson@its.uu.se> | 2007-03-16 15:00:07 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2007-03-16 15:00:07 -0700 |
| commit | d5cc4a73a5b5c8374b810d5371e9e7ed05c1e02c (patch) | |
| tree | 9fc98bedcecf6f910ec0c76f28e15fbda1ff6f1e /net/core/skbuff.c | |
| parent | db98e0b434a6265c451ffe94ec0a29b8d0aaf587 (diff) | |
| download | blackbird-op-linux-d5cc4a73a5b5c8374b810d5371e9e7ed05c1e02c.tar.gz blackbird-op-linux-d5cc4a73a5b5c8374b810d5371e9e7ed05c1e02c.zip | |
[IPV4]: Do not disable preemption in trie_leaf_remove().
Hello, Just discussed this Patrick...
We have two users of trie_leaf_remove, fn_trie_flush and fn_trie_delete
both are holding RTNL. So there shouldn't be need for this preempt stuff.
This is assumed to a leftover from an older RCU-take.
> Mhh .. I think I just remembered something - me incorrectly suggesting
> to add it there while we were talking about this at OLS :) IIRC the
> idea was to make sure tnode_free (which at that time didn't use
> call_rcu) wouldn't free memory while still in use in a rcu read-side
> critical section. It should have been synchronize_rcu of course,
> but with tnode_free using call_rcu it seems to be completely
> unnecessary. So I guess we can simply remove it.
Signed-off-by: Robert Olsson <robert.olsson@its.uu.se>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/skbuff.c')
0 files changed, 0 insertions, 0 deletions
