diff options
author | Bob Copeland <me@bobcopeland.com> | 2014-06-04 09:27:31 -0400 |
---|---|---|
committer | Johannes Berg <johannes.berg@intel.com> | 2014-06-23 11:05:27 +0200 |
commit | 2b470c39e895dfde5413b0a85fac928a353de48d (patch) | |
tree | 9f890c8927fbfb4bae1e252b77caace4793f008d /net/9p | |
parent | 5ac2e35030113ed881ce9ad413d80f13ffe5b5a0 (diff) | |
download | blackbird-op-linux-2b470c39e895dfde5413b0a85fac928a353de48d.tar.gz blackbird-op-linux-2b470c39e895dfde5413b0a85fac928a353de48d.zip |
mac80211: remove ignore_plink_timer flag
The mesh_plink code is doing some interesting things with the
ignore_plink_timer flag. It seems the original intent was to
handle this race:
cpu 0 cpu 1
----- -----
start timer handler for state X
acquire sta_lock
change state from X to Y
mod_timer() / del_timer()
release sta_lock
acquire sta_lock
execute state Y timer too soon
However, using the mod_timer()/del_timer() return values to
detect these cases is broken. As a result, timers get ignored
unnecessarily, and stations can get stuck in the peering state
machine.
Instead, we can detect the case by looking at the timer expiration.
In the case of del_timer, just ignore the timers in the following
(LISTEN/ESTAB) states since they won't have timers anyway.
Signed-off-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/9p')
0 files changed, 0 insertions, 0 deletions