summaryrefslogtreecommitdiffstats
path: root/net/802
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2012-05-08 18:56:46 +0000
committerDavid S. Miller <davem@davemloft.net>2012-05-09 20:49:17 -0400
commit28b29801b95de20405b2a11945cb6dfc7c6c84f9 (patch)
tree63b29d9295b2989eedf876717bc96432b72b0237 /net/802
parenta599b0f54d233d0f63d6be9a2ff0049d24751669 (diff)
downloadblackbird-op-linux-28b29801b95de20405b2a11945cb6dfc7c6c84f9.tar.gz
blackbird-op-linux-28b29801b95de20405b2a11945cb6dfc7c6c84f9.zip
802: Convert compare_ether_addr to ether_addr_equal
Use the new bool function ether_addr_equal to add some clarity and reduce the likelihood for misuse of compare_ether_addr for sorting. Done via cocci script: $ cat compare_ether_addr.cocci @@ expression a,b; @@ - !compare_ether_addr(a, b) + ether_addr_equal(a, b) @@ expression a,b; @@ - compare_ether_addr(a, b) + !ether_addr_equal(a, b) @@ expression a,b; @@ - !ether_addr_equal(a, b) == 0 + ether_addr_equal(a, b) @@ expression a,b; @@ - !ether_addr_equal(a, b) != 0 + !ether_addr_equal(a, b) @@ expression a,b; @@ - ether_addr_equal(a, b) == 0 + !ether_addr_equal(a, b) @@ expression a,b; @@ - ether_addr_equal(a, b) != 0 + ether_addr_equal(a, b) @@ expression a,b; @@ - !!ether_addr_equal(a, b) + ether_addr_equal(a, b) Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/802')
-rw-r--r--net/802/stp.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/802/stp.c b/net/802/stp.c
index 15540b7323cd..2c40ba0ec116 100644
--- a/net/802/stp.c
+++ b/net/802/stp.c
@@ -46,7 +46,7 @@ static int stp_pdu_rcv(struct sk_buff *skb, struct net_device *dev,
proto = rcu_dereference(garp_protos[eh->h_dest[5] -
GARP_ADDR_MIN]);
if (proto &&
- compare_ether_addr(eh->h_dest, proto->group_address))
+ !ether_addr_equal(eh->h_dest, proto->group_address))
goto err;
} else
proto = rcu_dereference(stp_proto);
OpenPOWER on IntegriCloud