summaryrefslogtreecommitdiffstats
path: root/mm
diff options
context:
space:
mode:
authorIlpo Järvinen <ilpo.jarvinen@helsinki.fi>2009-03-14 14:23:01 +0000
committerDavid S. Miller <davem@davemloft.net>2009-03-15 20:09:51 -0700
commit5861f8e58dd84fc34b691c2e8d4824dea68c360e (patch)
tree5c202f6866cca91ded45213cbb1a3d7f75fc6749 /mm
parent7cd0a63872ac6ef97265f07adc367ca4f984468e (diff)
downloadblackbird-op-linux-5861f8e58dd84fc34b691c2e8d4824dea68c360e.tar.gz
blackbird-op-linux-5861f8e58dd84fc34b691c2e8d4824dea68c360e.zip
tcp: remove pointless .dsack/.num_sacks code
In the pure assignment case, the earlier zeroing is still in effect. David S. Miller raised concerns if the ifs are there to avoid dirtying cachelines. I came to these conclusions: > We'll be dirty it anyway (now that I check), the first "real" statement > in tcp_rcv_established is: > > tp->rx_opt.saw_tstamp = 0; > > ...that'll land on the same dword. :-/ > > I suppose the blocks are there just because they had more complexity > inside when they had to calculate the eff_sacks too (maybe it would > have been better to just remove them in that drop-patch so you would > have had less head-ache :-)). Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'mm')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud