summaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorAnatol Pomozov <anatol.pomozov@gmail.com>2013-05-07 15:37:48 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2013-05-07 16:09:00 -0700
commit2d864e41710f1d2ba406fb62018ab0487152e6f2 (patch)
tree52c6a3172b7a4099830962323f2a1742fa166b01 /lib
parent292088ee032d0df59e7c8a7a00e9b97260146078 (diff)
downloadblackbird-op-linux-2d864e41710f1d2ba406fb62018ab0487152e6f2.tar.gz
blackbird-op-linux-2d864e41710f1d2ba406fb62018ab0487152e6f2.zip
kref: minor cleanup
- make warning smp-safe - result of atomic _unless_zero functions should be checked by caller to avoid use-after-free error - trivial whitespace fix. Link: https://lkml.org/lkml/2013/4/12/391 Tested: compile x86, boot machine and run xfstests Signed-off-by: Anatol Pomozov <anatol.pomozov@gmail.com> [ Removed line-break, changed to use WARN_ON_ONCE() - Linus ] Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib')
-rw-r--r--lib/kobject.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/kobject.c b/lib/kobject.c
index a65486613d79..b7e29a6056d3 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -529,7 +529,7 @@ struct kobject *kobject_get(struct kobject *kobj)
return kobj;
}
-static struct kobject *kobject_get_unless_zero(struct kobject *kobj)
+static struct kobject * __must_check kobject_get_unless_zero(struct kobject *kobj)
{
if (!kref_get_unless_zero(&kobj->kref))
kobj = NULL;
OpenPOWER on IntegriCloud