summaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorViresh Kumar <viresh.kumar@st.com>2011-08-05 15:32:40 +0530
committerVinod Koul <vinod.koul@intel.com>2011-08-25 19:33:39 +0530
commite0719165801fad04073e7dcd90e4afd02aba3fb7 (patch)
tree8b1cb65f26487d6fa0aba776e88c8e9b7f0aa22c /lib
parent03af500f743f486648fc8afc38593e9844411945 (diff)
downloadblackbird-op-linux-e0719165801fad04073e7dcd90e4afd02aba3fb7.tar.gz
blackbird-op-linux-e0719165801fad04073e7dcd90e4afd02aba3fb7.zip
dmaengine/amba-pl08x: Align lli_len to max(src.width, dst.width)
Currently lli_len is aligned to min of two widths, which looks to be incorrect. Instead it should be aligned to max of both widths. Lets say, total_size = 441 bytes MIN: lets check if min() suits or not: CASE 1: srcwidth = 1, dstwidth = 4 min(src, dst) = 1 i.e. We program transfer size in control reg to 441. Now, till 440 bytes everything is fine, but on the last byte DMAC can't transfer 1 byte to dst, as its width is 4. CASE 2: srcwidth = 4, dstwidth = 1 min(src, dst) = 1 i.e. we program transfer size in control reg to 110 (data transferred = 110 * srcwidth). So, here too 1 byte is left, but on the source side. MAX: Lets check if max() suits or not: CASE 3: srcwidth = 1, dstwidth = 4 max(src, dst) = 4 Aligned size is 440 i.e. We program transfer size in control reg to 440. Now, all 440 bytes will be transferred without any issues. CASE 4: srcwidth = 4, dstwidth = 1 max(src, dst) = 4 Aligned size is 440 i.e. We program transfer size in control reg to 110 (data transferred = 110 * srcwidth). Now, also all 440 bytes will be transferred without any issues. Signed-off-by: Viresh Kumar <viresh.kumar@st.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud