diff options
| author | Arjan van de Ven <arjan@linux.intel.com> | 2008-07-25 19:45:39 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-26 12:00:07 -0700 |
| commit | 5cd2b459d326a424671dcd95f038649f7bf7cb96 (patch) | |
| tree | 824514753e173bb69d3fde5fab18f8ddf909751d /lib/plist.c | |
| parent | f810a5cf28a818db96333cd23646f0227ec015b4 (diff) | |
| download | blackbird-op-linux-5cd2b459d326a424671dcd95f038649f7bf7cb96.tar.gz blackbird-op-linux-5cd2b459d326a424671dcd95f038649f7bf7cb96.zip | |
Use WARN() in lib/
Use WARN() instead of a printk+WARN_ON() pair; this way the message becomes
part of the warning section for better reporting/collection. In addition, one
of the if() clauses collapes into the WARN() entirely now.
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib/plist.c')
| -rw-r--r-- | lib/plist.c | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/lib/plist.c b/lib/plist.c index 3074a02272f3..d6c64a824e1d 100644 --- a/lib/plist.c +++ b/lib/plist.c @@ -31,12 +31,13 @@ static void plist_check_prev_next(struct list_head *t, struct list_head *p, struct list_head *n) { - if (n->prev != p || p->next != n) { - printk("top: %p, n: %p, p: %p\n", t, t->next, t->prev); - printk("prev: %p, n: %p, p: %p\n", p, p->next, p->prev); - printk("next: %p, n: %p, p: %p\n", n, n->next, n->prev); - WARN_ON(1); - } + WARN(n->prev != p || p->next != n, + "top: %p, n: %p, p: %p\n" + "prev: %p, n: %p, p: %p\n" + "next: %p, n: %p, p: %p\n", + t, t->next, t->prev, + p, p->next, p->prev, + n, n->next, n->prev); } static void plist_check_list(struct list_head *top) |
