diff options
| author | Matthew Wilcox <matthew@wil.cx> | 2008-08-12 07:13:14 -0600 |
|---|---|---|
| committer | Jeff Garzik <jgarzik@redhat.com> | 2008-09-24 18:49:01 -0400 |
| commit | f382a0a8e9403c6d7f8b2cfa21e41fefb5d0c9bd (patch) | |
| tree | 2fa31ffb8dc9c32d5e497309c3388e57f19b9e95 /include | |
| parent | 70666c71957b62c8e9ea5c0d999a4bfd214c80d2 (diff) | |
| download | blackbird-op-linux-f382a0a8e9403c6d7f8b2cfa21e41fefb5d0c9bd.tar.gz blackbird-op-linux-f382a0a8e9403c6d7f8b2cfa21e41fefb5d0c9bd.zip | |
[netdrvr] atl1e: Don't take the mdio_lock in atl1e_probe
Lockdep warns about the mdio_lock taken with interrupts enabled then later
taken from interrupt context. Initially, I considered changing these
to spin_lock_irq/spin_unlock_irq, but then I looked at atl1e_phy_init()
and saw that it calls msleep(). Sleeping while holding a spinlock is
not allowed either.
In the probe path, we haven't registered the interrupt handler, so
it can't poke at this card yet. It's before we call register_netdev(),
so I don't think any other threads can reach this card either. If I'm
right, we don't need a spinlock at all.
Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions
