summaryrefslogtreecommitdiffstats
path: root/include/ras
diff options
context:
space:
mode:
authorDave Airlie <airlied@redhat.com>2014-07-24 11:53:45 +1000
committerDave Airlie <airlied@redhat.com>2014-08-04 16:54:02 +1000
commit2ee39452fa2fff1e8edb954ccb7e0daee9646557 (patch)
tree94e29c96825e2a90dd6a103caf07585eed8e49c6 /include/ras
parentf68d697eaf3278200a7fc3c8b1d95d72837b84d8 (diff)
downloadblackbird-op-linux-2ee39452fa2fff1e8edb954ccb7e0daee9646557.tar.gz
blackbird-op-linux-2ee39452fa2fff1e8edb954ccb7e0daee9646557.zip
drm: close race in connector registration (v2)
Daniel pointed out with hotplug that userspace could be trying to oops us as root for lols, and that to be correct we shouldn't register the object with the idr before we have fully set the connector object up. His proposed solution was a lot more life changing, this seemed like a simpler proposition to me, get the connector object id from the idr, but don't register the object until the drm_connector_register callback. The open question is whether the drm_mode_object_register needs a bigger lock than just the idr one, but I can't see why it would, but I can be locking challenged. v2: fix bool noreg into sane - add comment. Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Reviewed-by: David Herrmann <dh.herrmann@gmail.com> Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'include/ras')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud