diff options
| author | David S. Miller <davem@davemloft.net> | 2012-07-17 14:55:59 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-07-20 13:40:07 -0700 |
| commit | 2860583fe840d972573363dfa190b2149a604534 (patch) | |
| tree | 473a69bdcc3e45dd35bc0452a588cfbbac54c6e6 /include/net | |
| parent | 9917e1e8762745191eba5a3bf2040278cbddbee1 (diff) | |
| download | blackbird-op-linux-2860583fe840d972573363dfa190b2149a604534.tar.gz blackbird-op-linux-2860583fe840d972573363dfa190b2149a604534.zip | |
ipv4: Kill rt->fi
It's not really needed.
We only grabbed a reference to the fib_info for the sake of fib_info
local metrics.
However, fib_info objects are freed using RCU, as are therefore their
private metrics (if any).
We would have triggered a route cache flush if we eliminated a
reference to a fib_info object in the routing tables.
Therefore, any existing cached routes will first check and see that
they have been invalidated before an errant reference to these
metric values would occur.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net')
| -rw-r--r-- | include/net/route.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/net/route.h b/include/net/route.h index 4bafe0bfe829..60d611dc5cee 100644 --- a/include/net/route.h +++ b/include/net/route.h @@ -56,7 +56,6 @@ struct rtable { /* Miscellaneous cached information */ u32 rt_pmtu; - struct fib_info *fi; /* for client ref to shared metrics */ }; static inline bool rt_is_input_route(const struct rtable *rt) |
