diff options
| author | Lars Ellenberg <lars.ellenberg@linbit.com> | 2011-02-21 13:20:55 +0100 |
|---|---|---|
| committer | Philipp Reisner <philipp.reisner@linbit.com> | 2011-10-14 16:47:42 +0200 |
| commit | 4738fa16907a933d72bbcae1b8922dc9330fde92 (patch) | |
| tree | d0a48980a5269758ba01545b4200c548b30b0909 /include/linux/lru_cache.h | |
| parent | 61610420f764acb835af4a450251dbab2ab6d621 (diff) | |
| download | blackbird-op-linux-4738fa16907a933d72bbcae1b8922dc9330fde92.tar.gz blackbird-op-linux-4738fa16907a933d72bbcae1b8922dc9330fde92.zip | |
drbd: use clear_bit_unlock() where appropriate
Some open-coded clear_bit(); smp_mb__after_clear_bit();
should in fact have been smp_mb__before_clear_bit(); clear_bit();
Instead, use clear_bit_unlock() to annotate the intention,
and have it do the right thing.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Diffstat (limited to 'include/linux/lru_cache.h')
| -rw-r--r-- | include/linux/lru_cache.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/include/linux/lru_cache.h b/include/linux/lru_cache.h index 7a71ffad037c..4cceafb0732d 100644 --- a/include/linux/lru_cache.h +++ b/include/linux/lru_cache.h @@ -275,8 +275,7 @@ static inline int lc_try_lock(struct lru_cache *lc) */ static inline void lc_unlock(struct lru_cache *lc) { - clear_bit(__LC_DIRTY, &lc->flags); - smp_mb__after_clear_bit(); + clear_bit_unlock(__LC_DIRTY, &lc->flags); } static inline int lc_is_used(struct lru_cache *lc, unsigned int enr) |
