diff options
| author | Herbert Xu <herbert@gondor.apana.org.au> | 2006-09-29 01:59:06 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-09-29 09:18:06 -0700 |
| commit | 684f978347deb42d180373ac4c427f82ef963171 (patch) | |
| tree | db9025d8c6b267565c7110e09b16193957186a48 /include/linux/hdsmart.h | |
| parent | 6299a2dec89d22940e36832f15c0addfb77e6910 (diff) | |
| download | blackbird-op-linux-684f978347deb42d180373ac4c427f82ef963171.tar.gz blackbird-op-linux-684f978347deb42d180373ac4c427f82ef963171.zip | |
[PATCH] Let WARN_ON/WARN_ON_ONCE return the condition
Letting WARN_ON/WARN_ON_ONCE return the condition means that you could do
if (WARN_ON(blah)) {
handle_impossible_case
}
Rather than
if (unlikely(blah)) {
WARN_ON(1)
handle_impossible_case
}
I checked all the newly added WARN_ON_ONCE users and none of them test the
return status so we can still change it.
[akpm@osdl.org: warning fix]
[akpm@osdl.org: build fix]
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'include/linux/hdsmart.h')
0 files changed, 0 insertions, 0 deletions
