summaryrefslogtreecommitdiffstats
path: root/include/linux/ata_platform.h
diff options
context:
space:
mode:
authorHidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>2009-12-14 17:10:06 +0900
committerLen Brown <len.brown@intel.com>2009-12-16 04:13:19 -0500
commit918aae42aa9b611a3663b16ae849fdedc67c2292 (patch)
tree7c152725227444722143bf9e2a7032223d632688 /include/linux/ata_platform.h
parentf67538f81e6b8da9175c82807d649fbdb0055844 (diff)
downloadblackbird-op-linux-918aae42aa9b611a3663b16ae849fdedc67c2292.tar.gz
blackbird-op-linux-918aae42aa9b611a3663b16ae849fdedc67c2292.zip
ACPI: fix for lapic_timer_propagate_broadcast()
I got following warning on ia64 box: In function 'acpi_processor_power_verify': 642: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type This smp_call_function_single() was introduced by a commit f833bab87fca5c3ce13778421b1365845843b976: > @@ -162,8 +162,9 @@ > pr->power.timer_broadcast_on_state = state; > } > > -static void lapic_timer_propagate_broadcast(struct acpi_processor *pr) > +static void lapic_timer_propagate_broadcast(void *arg) > { > + struct acpi_processor *pr = (struct acpi_processor *) arg; > unsigned long reason; > > reason = pr->power.timer_broadcast_on_state < INT_MAX ? > @@ -635,7 +636,8 @@ > working++; > } > > - lapic_timer_propagate_broadcast(pr); > + smp_call_function_single(pr->id, lapic_timer_propagate_broadcast, > + pr, 1); > > return (working); > } The problem is that the lapic_timer_propagate_broadcast() has 2 versions: One is real code that modified in the above commit, and the other is NOP code that used when !ARCH_APICTIMER_STOPS_ON_C3: static void lapic_timer_propagate_broadcast(struct acpi_processor *pr) { } So I got warning because of !ARCH_APICTIMER_STOPS_ON_C3. We really want to do nothing here on !ARCH_APICTIMER_STOPS_ON_C3, so modify lapic_timer_propagate_broadcast() of real version to use smp_call_function_single() in it. Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com> Acked-by: Suresh Siddha <suresh.b.siddha@intel.com> Signed-off-by: Len Brown <len.brown@intel.com>
Diffstat (limited to 'include/linux/ata_platform.h')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud