diff options
| author | Miao Xie <miaox@cn.fujitsu.com> | 2014-07-24 11:37:07 +0800 |
|---|---|---|
| committer | Chris Mason <clm@fb.com> | 2014-08-19 08:52:17 -0700 |
| commit | 5d68da3b8ee6eb2257aa4b8d885581782278ae93 (patch) | |
| tree | 0656b0f5fa96f81c042467ee971a1cedeb1320f9 /fs | |
| parent | ff61d17c6324d1b483fbbc5144f09668c24ff60c (diff) | |
| download | blackbird-op-linux-5d68da3b8ee6eb2257aa4b8d885581782278ae93.tar.gz blackbird-op-linux-5d68da3b8ee6eb2257aa4b8d885581782278ae93.zip | |
Btrfs: don't write any data into a readonly device when scrub
We should not write data into a readonly device especially seed device when
doing scrub, skip those devices.
Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
Reviewed-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Chris Mason <clm@fb.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/btrfs/scrub.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c index b6d198f5181e..23d3f6e6a482 100644 --- a/fs/btrfs/scrub.c +++ b/fs/btrfs/scrub.c @@ -2904,6 +2904,7 @@ int btrfs_scrub_dev(struct btrfs_fs_info *fs_info, u64 devid, u64 start, struct scrub_ctx *sctx; int ret; struct btrfs_device *dev; + struct rcu_string *name; if (btrfs_fs_closing(fs_info)) return -EINVAL; @@ -2965,6 +2966,16 @@ int btrfs_scrub_dev(struct btrfs_fs_info *fs_info, u64 devid, u64 start, return -ENODEV; } + if (!is_dev_replace && !readonly && !dev->writeable) { + mutex_unlock(&fs_info->fs_devices->device_list_mutex); + rcu_read_lock(); + name = rcu_dereference(dev->name); + btrfs_err(fs_info, "scrub: device %s is not writable", + name->str); + rcu_read_unlock(); + return -EROFS; + } + mutex_lock(&fs_info->scrub_lock); if (!dev->in_fs_metadata || dev->is_tgtdev_for_dev_replace) { mutex_unlock(&fs_info->scrub_lock); |
