diff options
| author | Steve French <sfrench@us.ibm.com> | 2008-01-20 00:30:29 +0000 |
|---|---|---|
| committer | Steve French <sfrench@us.ibm.com> | 2008-01-20 00:30:29 +0000 |
| commit | ed2b91701d97047fa9970645e43d5e551e261adb (patch) | |
| tree | 968ebd96c6cefbb56f5dad7e3b5b8ebd38ee5c2b /fs | |
| parent | e6ab15827eec0bc4444421f7ccf0223de321c708 (diff) | |
| download | blackbird-op-linux-ed2b91701d97047fa9970645e43d5e551e261adb.tar.gz blackbird-op-linux-ed2b91701d97047fa9970645e43d5e551e261adb.zip | |
[CIFS] Do not log path names in lookup errors
Andi Kleen noticed that we were logging access denied errors (which is
noisy in the dmesg log, and not needed to be logged) and that we were
logging path names on that an other errors (e.g. EIO) which we should
not be doing.
CC: Andi Kleen <ak@suse.de>
Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/cifs/dir.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c index 37dc97af1487..699ec1198409 100644 --- a/fs/cifs/dir.c +++ b/fs/cifs/dir.c @@ -517,12 +517,10 @@ cifs_lookup(struct inode *parent_dir_inode, struct dentry *direntry, d_add(direntry, NULL); /* if it was once a directory (but how can we tell?) we could do shrink_dcache_parent(direntry); */ - } else { - cERROR(1, ("Error 0x%x on cifs_get_inode_info in lookup of %s", - rc, full_path)); - /* BB special case check for Access Denied - watch security - exposure of returning dir info implicitly via different rc - if file exists or not but no access BB */ + } else if (rc != -EACCES) { + cERROR(1, ("Unexpected lookup error %d", rc)); + /* We special case check for Access Denied - since that + is a common return code */ } kfree(full_path); |
