summaryrefslogtreecommitdiffstats
path: root/fs/xfs/xfs_inode_item.c
diff options
context:
space:
mode:
authorBrian Foster <bfoster@redhat.com>2015-08-19 09:51:43 +1000
committerDave Chinner <david@fromorbit.com>2015-08-19 09:51:43 +1000
commit6bc43af3d5f507254b8de2058ea51f6ec998ae52 (patch)
treeebad0b58bcb29f90c861705aba3428bf50456b77 /fs/xfs/xfs_inode_item.c
parent8d99fe92fed019e203f458370129fb28b3fb5740 (diff)
downloadblackbird-op-linux-6bc43af3d5f507254b8de2058ea51f6ec998ae52.tar.gz
blackbird-op-linux-6bc43af3d5f507254b8de2058ea51f6ec998ae52.zip
xfs: ensure EFD trans aborts on log recovery extent free failure
Log recovery attempts to free extents with leftover EFIs in the AIL after initial processing. If the extent free fails (e.g., due to unrelated fs corruption), the transaction is cancelled, though it might not be dirtied at the time. If this is the case, the EFD does not abort and thus does not release the EFI. This can lead to hangs as the EFI pins the AIL. Update xlog_recover_process_efi() to log the EFD in the transaction before xfs_free_extent() errors are handled to ensure the transaction is dirty, aborts the EFD and releases the EFI on error. Since this is a requirement for EFD processing (and consistent with xfs_bmap_finish()), update the EFD logging helper to do the extent free and unconditionally log the EFD. This encodes the required EFD logging behavior into the helper and reduces the likelihood of errors down the road. [dchinner: re-add xfs_alloc.h to xfs_log_recover.c to fix build failure.] Signed-off-by: Brian Foster <bfoster@redhat.com> Reviewed-by: Dave Chinner <dchinner@redhat.com> Signed-off-by: Dave Chinner <david@fromorbit.com>
Diffstat (limited to 'fs/xfs/xfs_inode_item.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud