diff options
author | Christoph Hellwig <hch@infradead.org> | 2008-07-18 17:12:36 +1000 |
---|---|---|
committer | Niv Sardi <xaiki@debian.org> | 2008-07-28 16:59:28 +1000 |
commit | 62a877e35d5085c65936ed3194d1bbaf84f419e1 (patch) | |
tree | 76f16d460d8eec4f1d39bb533167e591bb6113c6 /fs/xfs/linux-2.6/xfs_stats.h | |
parent | deeb5912db12e8b7ccf3f4b1afaad60bc29abed9 (diff) | |
download | blackbird-op-linux-62a877e35d5085c65936ed3194d1bbaf84f419e1.tar.gz blackbird-op-linux-62a877e35d5085c65936ed3194d1bbaf84f419e1.zip |
[XFS] fix mount option parsing in remount
Remount currently happily accept any option thrown at it, although the
only filesystem specific option it actually handles is barrier/nobarrier.
And it actually doesn't handle these correctly either because it only uses
the value it parsed when we're doing a ro->rw transition. In addition to
that there's also a bad bug in xfs_parseargs which doesn't touch the
actual option in the mount point except for a single one,
XFS_MOUNT_SMALL_INUMS and thus forced any filesystem that's every
remounted in some way to not support 64bit inodes with no way to recover
unless unmounted.
This patch changes xfs_fs_remount to use it's own linux/parser.h based
options parse instead of xfs_parseargs and reject all options except for
barrier/nobarrier and to the right thing in general. Eventually I'd like
to have a single big option table used for mount aswell but that can wait
for a while.
SGI-PV: 983964
SGI-Modid: xfs-linux-melb:xfs-kern:31382a
Signed-off-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Tim Shimmin <tes@sgi.com>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
Diffstat (limited to 'fs/xfs/linux-2.6/xfs_stats.h')
0 files changed, 0 insertions, 0 deletions