diff options
| author | Jens Axboe <jens.axboe@oracle.com> | 2010-05-17 12:55:07 +0200 |
|---|---|---|
| committer | Jens Axboe <jens.axboe@oracle.com> | 2010-05-17 12:55:07 +0200 |
| commit | e913fc825dc685a444cb4c1d0f9d32f372f59861 (patch) | |
| tree | e470697e43ffe4028ac81c17d3ef90ee9f30bcfb /fs/sync.c | |
| parent | 69b62d01ec44fe0d505d89917392347732135a4d (diff) | |
| download | blackbird-op-linux-e913fc825dc685a444cb4c1d0f9d32f372f59861.tar.gz blackbird-op-linux-e913fc825dc685a444cb4c1d0f9d32f372f59861.zip | |
writeback: fix WB_SYNC_NONE writeback from umount
When umount calls sync_filesystem(), we first do a WB_SYNC_NONE
writeback to kick off writeback of pending dirty inodes, then follow
that up with a WB_SYNC_ALL to wait for it. Since umount already holds
the sb s_umount mutex, WB_SYNC_NONE ends up doing nothing and all
writeback happens as WB_SYNC_ALL. This can greatly slow down umount,
since WB_SYNC_ALL writeback is a data integrity operation and thus
a bigger hammer than simple WB_SYNC_NONE. For barrier aware file systems
it's a lot slower.
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'fs/sync.c')
| -rw-r--r-- | fs/sync.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/sync.c b/fs/sync.c index 92b228176f7c..de6a44192832 100644 --- a/fs/sync.c +++ b/fs/sync.c @@ -42,7 +42,7 @@ static int __sync_filesystem(struct super_block *sb, int wait) if (wait) sync_inodes_sb(sb); else - writeback_inodes_sb(sb); + writeback_inodes_sb_locked(sb); if (sb->s_op->sync_fs) sb->s_op->sync_fs(sb, wait); |
