diff options
author | Dave Hansen <dave@linux.vnet.ibm.com> | 2011-05-24 17:11:41 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-05-25 08:39:11 -0700 |
commit | 15fa8f425557a0d698f933627771f520ef4ae34b (patch) | |
tree | 033020d146cef836681d56f570fb6b0116ac5794 /fs/squashfs | |
parent | 72788c385604523422592249c19cba0187021e9b (diff) | |
download | blackbird-op-linux-15fa8f425557a0d698f933627771f520ef4ae34b.tar.gz blackbird-op-linux-15fa8f425557a0d698f933627771f520ef4ae34b.zip |
include/linux/gfp.h: work around apparent sparse confusion
Running sparse on page_alloc.c today, it errors out:
include/linux/gfp.h:254:17: error: bad constant expression
include/linux/gfp.h:254:17: error: cannot size expression
which is a line in gfp_zone():
BUILD_BUG_ON((GFP_ZONE_BAD >> bit) & 1);
That's really unfortunate, because it ends up hiding all of the other
legitimate sparse messages like this:
mm/page_alloc.c:5315:59: warning: incorrect type in argument 1 (different base types)
mm/page_alloc.c:5315:59: expected unsigned long [unsigned] [usertype] size
mm/page_alloc.c:5315:59: got restricted gfp_t [usertype] <noident>
...
Having sparse be able to catch these very oopsable bugs is a lot more
important than keeping a BUILD_BUG_ON(). Kill the BUILD_BUG_ON().
Compiles on x86_64 with and without CONFIG_DEBUG_VM=y. defconfig boots
fine for me.
Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/squashfs')
0 files changed, 0 insertions, 0 deletions