diff options
author | Tristan Ye <tristan.ye@oracle.com> | 2010-03-19 09:21:10 +0800 |
---|---|---|
committer | Joel Becker <joel.becker@oracle.com> | 2010-03-23 18:22:55 -0700 |
commit | b54c2ca475fa7d7450a45b6d778dae9dbe0bcbfe (patch) | |
tree | a67f530a3f426d756a0383f8dc11b5928810d0f5 /fs/ocfs2/quota_local.c | |
parent | 3939fda4b389993caf8741df5739b3e49f33a263 (diff) | |
download | blackbird-op-linux-b54c2ca475fa7d7450a45b6d778dae9dbe0bcbfe.tar.gz blackbird-op-linux-b54c2ca475fa7d7450a45b6d778dae9dbe0bcbfe.zip |
Ocfs2: Handle deletion of reflinked oprhan inodes correctly.
The rule is that all inodes in the orphan dir have ORPHANED_FL,
otherwise we treated it as an ERROR. This rule works well except
for some rare cases of reflink operation:
http://oss.oracle.com/bugzilla/show_bug.cgi?id=1215
The problem is caused by how reflink and our orphan_scan thread
interact.
* The orphan scan pulls the orphans into a queue first, then runs the
queue at a later time. We only hold the orphan_dir's lock
during scanning.
* Reflink create a oprhaned target in orphan_dir as its first step.
It removes the target and clears the flag as the final step.
These two steps take the orphan_dir's lock, but it is not held for
the duration.
Based on the above semantics, a reflink inode can be moved out of the
orphan dir and have its ORPHANED_FL cleared before the queue of orphans
is run. This leads to a ERROR in ocfs2_query_wipde_inode().
This patch teaches ocfs2_query_wipe_inode() to detect previously
orphaned reflink targets. If a reflink fails or a crash occurs during
the relfink operation, the inode will retain ORPHANED_FL and will be
properly wiped.
Signed-off-by: Tristan Ye <tristan.ye@oracle.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
Diffstat (limited to 'fs/ocfs2/quota_local.c')
0 files changed, 0 insertions, 0 deletions